-
Notifications
You must be signed in to change notification settings - Fork 14.5k
[Clang-Repl] Add support for out-of-process execution. #110418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
519dd2c
[Clang-Repl] Implement out-of-process execution interface for clang-repl
SahilPatidar 621420f
Refactor and improve initial code structure
SahilPatidar 94dec75
Add shared memory support
SahilPatidar b29ea82
Fix code format
SahilPatidar 89d0fe0
Fix orc runtime path
SahilPatidar b02b0da
Refactor Code
SahilPatidar a4e48bc
Add checks in sanitizeOopArguments to handle cases where remote execu…
SahilPatidar 3143d88
Update LoadDynamicLibrary method to use EPC Search Generator for out-…
SahilPatidar 9673ec8
Update: Propagate error instead of using `ExitOnErr`
SahilPatidar a50d7d3
Fix code format
SahilPatidar 06132c8
Refactor: Improve logic and remove hardcoded Clang version
SahilPatidar 7fa02cc
Fix: Apply lhames suggested fix for Clang-REPL crash
SahilPatidar 527d39f
Add platform support check in `sanitizeOopArguments`
SahilPatidar 14d6e13
Fix code format
SahilPatidar c1f2760
Fix: Add default value for --orc-runtime option.
SahilPatidar 2bcfcb3
Merge branch 'main' into clang-repl
SahilPatidar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
//===-- RemoteJITUtils.h - Utilities for remote-JITing ----------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Utilities for ExecutorProcessControl-based remote JITing with Orc and | ||
// JITLink. | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_CLANG_INTERPRETER_REMOTEJITUTILS_H | ||
#define LLVM_CLANG_INTERPRETER_REMOTEJITUTILS_H | ||
|
||
#include "llvm/ADT/StringRef.h" | ||
#include "llvm/ExecutionEngine/Orc/Core.h" | ||
#include "llvm/ExecutionEngine/Orc/Layer.h" | ||
#include "llvm/ExecutionEngine/Orc/SimpleRemoteEPC.h" | ||
#include "llvm/Support/Error.h" | ||
|
||
#include <cstdint> | ||
#include <memory> | ||
#include <string> | ||
|
||
llvm::Expected<std::unique_ptr<llvm::orc::SimpleRemoteEPC>> | ||
launchExecutor(llvm::StringRef ExecutablePath, bool UseSharedMemory, | ||
llvm::StringRef SlabAllocateSizeString); | ||
|
||
/// Create a JITLinkExecutor that connects to the given network address | ||
/// through a TCP socket. A valid NetworkAddress provides hostname and port, | ||
/// e.g. localhost:20000. | ||
llvm::Expected<std::unique_ptr<llvm::orc::SimpleRemoteEPC>> | ||
connectTCPSocket(llvm::StringRef NetworkAddress, bool UseSharedMemory, | ||
llvm::StringRef SlabAllocateSizeString); | ||
|
||
#endif // LLVM_CLANG_INTERPRETER_REMOTEJITUTILS_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not default to in-process and only if we require out-of-process to set these things specifically for out-of-process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EPC
isExecutorProcessControl
-- using these variants means that the system works regardless of the underlying implementation (SelfExecutorProcessControl
vsSimpleRemoteEPC
), whereas usingDynamicLibrarySearchGenerator
only works in the current process.Eventually I want to get rid of the Non-EPC variants. I might even invert the naming scheme and start calling the old ones "LegacyInProcess". :)