Skip to content

Add extendhfxf2 into compiler rt #113897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler-rt/lib/builtins/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ endif ()
# long double is not 80 bits on Android or MSVC.
set(x86_80_BIT_SOURCES
divxc3.c
extendhfxf2.c
extendxftf2.c
fixxfdi.c
fixxfti.c
Expand Down
16 changes: 16 additions & 0 deletions compiler-rt/lib/builtins/extendhfxf2.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//===-- lib/extendhfxf2.c - half -> long double conversion --------*- C -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "int_lib.h"
#define SRC_HALF
#define DST_DOUBLE
#include "fp_extend_impl.inc"

// Long double are expected to be as precise as double.
COMPILER_RT_ABI xf_float __extendhfxf2(src_t a) {
return (xf_float)__extendXfYf2__(a);
}
73 changes: 73 additions & 0 deletions compiler-rt/test/builtins/Unit/extendhfxf2_test.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// RUN: %clang_builtins %s %librt -o %t && %run %t
// REQUIRES: librt_has_extendhfxf2

#include <limits.h>
#include <math.h> // for isnan, isinf
#include <stdio.h>

#include "int_lib.h"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "fp_test.h"

#if HAS_80_BIT_LONG_DOUBLE && defined(COMPILER_RT_HAS_FLOAT16)

long double __extendhfxf2(_Float16 f);

int test_extendhfxf2(_Float16 a, long double expected) {
long double x = __extendhfxf2(a);
__uint16_t *b = (void *)&a;
int ret = !((isnan(x) && isnan(expected)) || x == expected);
if (ret) {
printf("error in test__extendhfxf2(%#.4x) = %.20Lf, "
"expected %.20Lf\n",
*b, x, expected);
}
return ret;
}

char assumption_1[sizeof(_Float16) * CHAR_BIT == 16] = {0};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can drop this


int main() {
// Small positive value
if (test_extendhfxf2(0.09997558593750000000f, 0.09997558593750000000L))
return 1;

// Small negative value
if (test_extendhfxf2(-0.09997558593750000000f, -0.09997558593750000000L))
return 1;

// Zero
if (test_extendhfxf2(0.0f, 0.0L))
return 1;

// Smallest positive non-zero value
if (test_extendhfxf2(0x1p-16f, 0x1p-16L))
return 1;

// Smallest negative non-zero value
if (test_extendhfxf2(-0x1p-16f, -0x1p-16L))
return 1;

// Positive infinity
if (test_extendhfxf2(__builtin_huge_valf16(), __builtin_huge_valf64x()))
return 1;

// Negative infinity
if (test_extendhfxf2(-__builtin_huge_valf16(),
(long double)-__builtin_huge_valf64x()))
return 1;

// NaN
if (test_extendhfxf2(__builtin_nanf16(""),
(long double)__builtin_nanf64x("")))
return 1;

return 0;
}

#else

int main() {
printf("skipped\n");
return 0;
}

#endif
Loading