SystemZ: Add support for __builtin_setjmp and __builtin_longjmp. #119257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…390x-linux-gnu to the test cases.
…undo accidental changes.
1. Using 64-bit virtual register instead of 32-bit in SystemZISelLowering.cpp for -mbackchain option. -verify-machineinstrs option exposed it. 2. Adding -verify-machineinstrs option to run llvm tests. 3. Using %clang_cc1 instead of %clang for clang test failure. 4. Fix issue with unused variable being used in assert().
uweigand
reviewed
Dec 10, 2024
llvm/docs/ExceptionHandling.rst
Outdated
| On certain targets (ARM, PowerPC, VE, X86), the front end places the | ||
| frame pointer in the first word and the stack pointer in the third word, | ||
| while the target implementation of this intrinsic fills in the remaining | ||
| words. On other targets (SystemZ), saving the calling context to the buffer is left completely to the target implementation. |
There was a problem hiding this comment.
This line is very long, can you add a line break?
|
|
||
| ; RUN: llc < %s -verify-machineinstrs -mtriple=s390x-linux-gnu | FileCheck %s | ||
|
|
||
| ; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck %s |
There was a problem hiding this comment.
Why do we need to run this twice? Apparently this gives the exact same output as the same FileCheck prefix matches both? If so, I don't think we need this. (Same for the other tests.)
…ceptionHandling.rst documentation.
uweigand
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes fixes for original pr##116642.
Implementation for __builtin_setjmp and __builtin_longjmp for SystemZ..