[flang-rt] Fixed uninitialized class member variable #127681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgrind complained that `OpenStatementState::pathLength_` was used before it was initialized, when a file was opened with `status='scratch'`. The code seems to expect that `pathLengh_` should be initialized to 0, so added default initialization to the declaration.
vdonaldson
approved these changes
Feb 18, 2025
wldfngrs
pushed a commit
to wldfngrs/llvm-project
that referenced
this pull request
Feb 19, 2025
valgrind complained that `OpenStatementState::pathLength_` was used before it was initialized, when a file was opened with `status='scratch'`. The code seems to expect that `pathLengh_` should be initialized to 0, so added default initialization to the declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valgrind complained that
OpenStatementState::pathLength_was used before it was initialized, when a file was opened withstatus='scratch'. The code seems to expect thatpathLengh_should be initialized to 0, so added default initialization to the declaration.