nonblocking/nonallocating attributes (was: nolock/noalloc)#84983

Merged

Sirraide merged 84 commits intollvm:mainfrom

dougsonos:nolock

Jun 24, 2024

Commits on Mar 12, 2024

Initial squash/cleanup
Doug Wyatt
committed
Cleanup, mostly code style
Doug Wyatt
committed
squash me
Doug Wyatt
committed
apply the in-tree clang-format (which seems subtly different from my system's local one)
Doug Wyatt
committed

Commits on Mar 13, 2024

Address most of the low-hanging fruit in the initial review feedback.
Doug Wyatt
committed

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 16, 2024

De-virtualize FunctionEffect; it's now a value type. Prepare for the uniquing table to be in ASTContext.
Doug Wyatt
committed
Remove unused parameters from FunctionEffect interface.
Doug Wyatt
committed
Don't merge effects back to Old on redeclaration
Doug Wyatt
committed

Commits on Mar 17, 2024

Fix: canInferOnFunction can't always get a TypeSourceInfo.
Doug Wyatt
committed

Commits on Mar 19, 2024

Commits on Mar 21, 2024

- Serialize FunctionEffectSet as part of a FunctionProtoType.
Doug Wyatt
committed
Don't repeat function names in diagnostics.
Doug Wyatt
committed

Commits on Apr 2, 2024

Functionality:
Doug Wyatt
committed

Commits on Apr 3, 2024

Merge remote-tracking branch 'llvm-origin/main' into nolock
Doug Wyatt
committed
Mass renaming: nolock/noalloc -> nonblocking/nonallocating
Doug Wyatt
committed
Remove vestigial FunctionEffect flags
Doug Wyatt
committed

Commits on Apr 4, 2024

ArrayRef<const FunctionEffect> -> ArrayRef<FunctionEffect> (it's already const)
Doug Wyatt
committed

Commits on Apr 5, 2024

Commits on Apr 10, 2024

Reinstate the warning that nonblocking/nonallocating should be accompanied by noexcept.
Doug Wyatt
committed
Groundwork for `nonblocking(expr)`
Doug Wyatt
committed
Low-hanging fruit in review feedback.
Doug Wyatt
committed

Commits on Apr 11, 2024

- During parsing, don't remove nonallocating when nonblocking is added; keep both.
Doug Wyatt
committed
- Get rid of ugly const_cast in Sema::CheckOverridingFunctionAttributes.
Doug Wyatt
committed
Split out the Objective-C tests into a separate source file.
Doug Wyatt
committed
Make FunctionEffectSet::operator==() more elegant.
Doug Wyatt
committed

Commits on Apr 13, 2024

Create a flat effect representation in FunctionProtoType. Renaming of multiple flavors of effect set.
Doug Wyatt
committed

Commits on Apr 15, 2024

Separate effects and conditions.
Doug Wyatt
committed

Commits on Apr 16, 2024

FunctionEffectCondExpr => FunctionEffectCondition
Doug Wyatt
committed
FunctionTypeEffectSet => FunctionEffectSet
Doug Wyatt
committed
nonblocking(cond) now parsed into new form.
Doug Wyatt
committed

Commits on Apr 18, 2024

wip with computed effects
Doug Wyatt
committed

Commits on Apr 23, 2024

- Inline the methods on Decl.
Doug Wyatt
committed
Merge llvm-origin/main into nolock
Doug Wyatt
committed

Commits on Apr 24, 2024

- Adapt to merge from main.
Doug Wyatt
committed
tiny cleanup
Doug Wyatt
committed

Commits on Apr 25, 2024

Merge main into nolock
Doug Wyatt
committed
Tests involving nonblocking(expression)
Doug Wyatt
committed

Commits on Apr 26, 2024

ASTReader: adapt to GlobalDeclID change
Doug Wyatt
committed
warn_perf_constraint_implies_noexcept should only be issued in C++ without extern "C"
Doug Wyatt
committed

Commits on Apr 28, 2024

Obtain extern-C-ness from the function's canonical Decl.
Doug Wyatt
committed

Commits on Apr 29, 2024

Fix build problem involving std::any_of and a FunctionEffectsRef.
Doug Wyatt
committed

Commits on May 2, 2024

Remove AnalysisBasedWarnings debug code that was pulling in ASTMatchers.
Doug Wyatt
committed
Remove the 2nd pass caller/callee analysis/verification for now (to be a separate PR).
Doug Wyatt
committed
Merge branch 'main' into nolock
Doug Wyatt
committed
In Sema::ImpCastExprToType, the check for a nullptr source was
Doug Wyatt
committed
Better attribute documentation
Doug Wyatt
committed

Commits on May 3, 2024

- Remove disabling of future warning
Doug Wyatt
committed
Cleanup dead code.
Doug Wyatt
committed
- AttrDocs: add note about -W option to control diagnostics.
Doug Wyatt
committed

Commits on May 4, 2024

Review feedback, notably: FunctionEffectsRef invariants, mergeFunctionTypes().
Doug Wyatt
committed
Review feedback:
Doug Wyatt
committed

Commits on May 5, 2024

Detect and diagnose conflicts when merging effects between declarations.
Doug Wyatt
committed

Commits on May 6, 2024

In CheckOverridingFunctionAttributes, gather and report effect conflicts just once.
Doug Wyatt
committed
nonblocking(expr): Simplify ActOnEffectExpression, add tests.
Doug Wyatt
committed
- Require function prototypes in conjunction with the new attributes.
Doug Wyatt
committed

Commits on May 7, 2024

tighten up ActOnEffectExpression
Doug Wyatt
committed
More syntax tests.
Doug Wyatt
committed

Commits on May 16, 2024

Apply suggestions from code review

dougsonos
and
AaronBallman
authored
- review feedback: getCondition(), default-constructable iterator.
Doug Wyatt
committed
Remove the "clang_" prefix from the attribute spellings.
Doug Wyatt
committed
More review feedback.
Doug Wyatt
committed

Commits on May 17, 2024

- Clean up comments (trailing period).
Doug Wyatt
committed

Commits on May 21, 2024

TreeTransform is a class not a struct.
Doug Wyatt
committed
Merge branch 'main' into nolock
Doug Wyatt
committed

Commits on May 22, 2024

Add a positive test case per Aaron's feedback
Doug Wyatt
committed
Merge branch 'main' into nolock
Doug Wyatt
committed

Commits on May 24, 2024

Fix: read past end of Conditions array in FunctionEffectSet::insert.
Doug Wyatt
committed
Apply suggestions from code review

dougsonos
and
Sirraide
authored
FunctionEffectCondition => EffectConditionExpr, more minor review feedback
Doug Wyatt
committed
In FunctionEffectsRef::get(QualType QT), handle case of multiple levels
Doug Wyatt
committed

Commits on May 27, 2024

Merge llvm-origin/main into nolock
Doug Wyatt
committed
Review feedback:
Doug Wyatt
committed

Commits on Jun 18, 2024

Add tests suggested by Aaron Ballman.
Doug Wyatt
committed

Commits on Jun 20, 2024

Defer diagnosis of conflicting effect attributes when there is a condition involved.
Doug Wyatt
committed
tolerate/ignore redundant attributes
Doug Wyatt
committed
Merge remote-tracking branch 'llvm-origin/main' into nolock
Doug Wyatt
committed

Commits on Jun 21, 2024

Release notes
Doug Wyatt
committed
fix test failure (last merge from main changed how bool template arguments appear in AST dump)
Doug Wyatt
committed