Skip to content

Update the libc++/c++abi/unwind check for the Arm/Aarch64 cross toolchain builders. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vvereschaka
Copy link
Contributor

@vvereschaka vvereschaka commented Aug 28, 2024

Just return back to use check-<lib>-<target-triple> checks for the libc++/c++abi/unwind tests for the cross platform toolchain builders on Windows build hosts.

…hain builders.

Just return back to use 'check-<lib>-<target-triple> checks for the libc++/c++abi/unwind
tests for the cross platform toolchain builders on Windows build hosts.
@vvereschaka vvereschaka self-assigned this Aug 28, 2024
@vvereschaka
Copy link
Contributor Author

Also these changes fix the following libc++ tests on the Arm/Aarch64 cross toolchain builders

Ref llvm-project PR: llvm/llvm-project#96910

@vvereschaka vvereschaka requested a review from gkistanova August 28, 2024 20:28
@vvereschaka
Copy link
Contributor Author

The builders have been temporarily moved to the staging master until passing the libc++ tests

@vvereschaka vvereschaka marked this pull request as ready for review August 28, 2024 20:38
Copy link
Contributor

@gkistanova gkistanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vvereschaka vvereschaka merged commit c007b21 into llvm:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants