Price in cart rule#27470

[gixid192]

Description (*)

Price in cart only calculates based on 1 qty

Fixed Issues (if relevant)

1. Fixes 'Price in cart' condition in shopping cart price rule is not working properly #27470

Questions or comments

I saw the code has 2 comments from Magento team, added long ago since 2014

1. This is from 2014: /@todo reimplement this method when is fixed MAGETWO-5713.
   I'm not sure if they are about to reimplement it, but due to the time and the error, I just put the code here so that it can work as expected.
2. possible bug: need to use $model->getBasePrice()
   This is from this file created. Because it's been a long time, and none is asking about it so I think it will be alright to leave it there.

Please let me know what kind of tests should I write for this PR. Thanks!

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @gixid192. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[gixid192]

@magento run all tests

[gixid192]

@magento run Integration Tests, Functional Tests B2B, Functional Tests EE, WebAPI Tests