-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix overlap display issue in cms page privacy theme luma #32927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overlap display issue in cms page privacy theme luma #32927
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks as useful solution
Hi @Den4ik, thank you for the review. |
✔️ QA passed |
Hello @mrtuvn, @ptylek and @Den4ik I am a new QA engineer and would like to test this Pull Request to unblock and speed up the delivery.
Before PR fix in Chrome, Firefox, Microsoft Edge and Opera browsers (screenshots are below). |
@engcom-Alfa You may reproduce and test it with installed sample data from https://github.com/magento/magento2-sample-data |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Privacy Policy page header overlapping to Privacy Menu After: ✔️ Privacy Menu and page header are aligned properly Tested the same UI alignment navigating from different UI pages like; Home page, product page, category page, cart page etc! |
Hi @mrtuvn, thank you for your contribution! |
Description (*)
Small change in less styles to avoid overlap visual in cms page privacy-policy theme luma
from mobile screen resolution (<768px)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)