Skip to content

Fix overlap display issue in cms page privacy theme luma #32927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented May 2, 2021

Description (*)

Small change in less styles to avoid overlap visual in cms page privacy-policy theme luma
from mobile screen resolution (<768px)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes CMS menu issue - Luma Theme #32926

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 2, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor Author

mrtuvn commented May 3, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 3, 2021
@mrtuvn
Copy link
Contributor Author

mrtuvn commented May 3, 2021

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label May 3, 2021
@mrtuvn mrtuvn requested a review from ptylek May 4, 2021 03:33
@Den4ik Den4ik self-assigned this May 17, 2021
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks as useful solution

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9090 has been created to process this Pull Request

@dmitriyprime
Copy link
Contributor

✔️ QA passed

@gabrieldagama gabrieldagama removed the Priority: P3 May be fixed according to the position in the backlog. label Jun 4, 2021
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jun 24, 2021

Hello @mrtuvn, @ptylek and @Den4ik
Thank you for your contribution and collaboration!

I am a new QA engineer and would like to test this Pull Request to unblock and speed up the delivery.
Unfortunately, with the current description, I do not see how it can be tested.
Could you please provide more details on how it can be tested?
For example

  • Steps to reproduce and actual/expected result. That I can use to check previous and current behavior to confirm it is fixed.
  • Any functional user flows that can be affected by such changes
  • Any other advice/ recommendations that will allow us to test it

Before PR fix in Chrome, Firefox, Microsoft Edge and Opera browsers (screenshots are below).
image

@Den4ik
Copy link
Contributor

Den4ik commented Jun 24, 2021

@engcom-Alfa You may reproduce and test it with installed sample data from https://github.com/magento/magento2-sample-data

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jun 25, 2021

✔️ QA Passed

Preconditions:

  1. Have a theme luma setup
  2. Sample data should be upgraded

Manual testing scenario:

  1. Home page, click on "Privacy and Cookie Policy" from footer. Validate by resizing the browser to mobile/ tab sizes.

  2. Category page, click on "Privacy and Cookie Policy" from footer. Validate by resizing the browser to mobile/ tab sizes.

  3. Product details page, click on "Privacy and Cookie Policy" from footer. Validate by resizing the browser to mobile/ tab sizes.

Before: ✖️ Privacy Policy page header overlapping to Privacy Menu

image

After: ✔️ Privacy Menu and page header are aligned properly

image

Tested the same UI alignment navigating from different UI pages like; Home page, product page, category page, cart page etc!
Tested using different browsers like Chrome, Firefox, Microsoft edge

@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2021

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS menu issue - Luma Theme
6 participants