Skip to content

#33094 Renamed confusing store select labels - Login As Customer #33097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2021
Merged

#33094 Renamed confusing store select labels - Login As Customer #33097

merged 2 commits into from
Jul 29, 2021

Conversation

vovsky
Copy link
Contributor

@vovsky vovsky commented May 28, 2021

Description (*)

Renamed confusing store select labels at admin login as customers related config and modal window

Fixed Issues (if relevant)

  1. Fixes Rename confusing store select labels at admin login as customers related config and modal window #33094

Manual testing scenarios (*)

  1. Set Store View To Login To to Manual Selection in Stores -> Configuration -> Customers -> Login as Customer
  2. Go to Customer edit page and click Login as Customer

@m2-assistant
Copy link

m2-assistant bot commented May 28, 2021

Hi @vovsky. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Area: Frontend Component: LoginAsCustomerAdminUi Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 28, 2021
@Den4ik Den4ik self-requested a review May 29, 2021 20:22
@Den4ik Den4ik self-assigned this May 29, 2021
@Den4ik
Copy link
Contributor

Den4ik commented May 29, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented May 29, 2021

@vovsky Thanks for work on this PR. Could you also update error message at https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/LoginAsCustomerAdminUi/Controller/Adminhtml/Login/Login.php#L203

@vovsky
Copy link
Contributor Author

vovsky commented May 31, 2021

@vovsky Thanks for work on this PR. Could you also update error message at https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/LoginAsCustomerAdminUi/Controller/Adminhtml/Login/Login.php#L203

Updated. Thank you

@vovsky
Copy link
Contributor Author

vovsky commented May 31, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jun 1, 2021

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review and removed Progress: needs update labels Jun 1, 2021
@Den4ik
Copy link
Contributor

Den4ik commented Jun 2, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jun 3, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik
Den4ik approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved

Failed test is not related to PR changes.

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9111 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Den4ik Den4ik added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 3, 2021
@Den4ik
Copy link
Contributor

Den4ik commented Jun 3, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jun 3, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jun 7, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie engcom-Charlie self-assigned this Jun 25, 2021
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jul 1, 2021 •
edited
Loading

✔️ QA Passed

Preconditions:

  1. Set Multiwebsite, store and store view

Manual testing scenario:

  1. Set “Store View To Login To” to “Manual Selection” in Stores -> Configuration -> Customers -> Login as Customer
  2. Go to Customer edit page and click Login as Customer

Actual Result: ✔️

  1. Label should come as  “Store To Login To”  in Stores -> Configuration -> Customers -> Login as Customer
  2. Store selection label is coming Store

After: ✔️

image

image

Before: ✖️

image

image

Tested all the manual scenarios, no impact on regression testing.

@gabrieldagama gabrieldagama mentioned this pull request Jul 29, 2021
Closed
5 tasks
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2021
@gabrieldagama
ENGCOM-9111: #33094 Renamed confusing store select labels - Login As …
90ed3b2 
…Customer #33097
@magento-engcom-team magento-engcom-team merged commit fb1e4e1 into magento:2.4-develop Jul 29, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2021

Hi @vovsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@engcom-Charlie engcom-Charlie

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: LoginAsCustomer Component: LoginAsCustomerAdminUi Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename confusing store select labels at admin login as customers related config and modal window
4 participants
@vovsky @Den4ik @magento-engcom-team @engcom-Charlie