Skip to content

MFTF: Print Packing Slips Without Created Shipment Test #33341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Jun 24, 2021

This PR contains a test for asserting error, when the admin prints packing slips without created shipment.

Steps to reproduce
1 - Place an order on FE
2- Navigate to Admin Order Grid
3 - Find placed order
4 - Print packing slips
5 - Perform Assertions

Resolved issues:

  1. resolves [Issue] MFTF: Print Packing Slips Without Created Shipment Test #33345: MFTF: Print Packing Slips Without Created Shipment Test

@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2021

Hi @DmitryTsymbal. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 24, 2021
@DmitryTsymbal
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@shikhamis11 shikhamis11 self-requested a review June 24, 2021 15:39
@shikhamis11
Copy link
Member

@magento create issue

@eduard13 eduard13 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Jun 25, 2021
@eduard13 eduard13 self-assigned this Jun 25, 2021
@eduard13
Copy link
Contributor

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Jun 25, 2021
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-9132 has been created to process this Pull Request

@m2-community-project m2-community-project bot added Progress: testing in progress Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for testing and removed Progress: ready for testing Progress: testing in progress labels Jul 6, 2021
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jul 7, 2021

✔️ QA Passed

Preconditions:

  1. Magento 2.4

Manual testing scenario:

1 - Place an order on store front using Money order payment method with flat rate
2 - Navigate to Admin Order Grid
3 - Find the above pending order
4 - Select the order and click on Print packing slip option from Actions drop down
5 - For above steps also run the MFTF test

Existing admin error message:
image

Actual Result: ✔️

  1. Assertion is error should gets display as per admin as “There are no printable documents related to selected orders.”

After: ✔️

image

image

image

image

@sdzhepa sdzhepa removed the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jul 15, 2021
@magento-engcom-team magento-engcom-team merged commit 1188d1d into magento:2.4-develop Jul 29, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2021

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Print Packing Slips Without Created Shipment Test
7 participants