Support different lenght of extended address #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, many thanks for contribution. please check first, if unit tests passing, and add some test cases for this extended address feature. |
|
Test added, thank you for the awesome project! |
4 tasks
|
Hi @marcinbor85, |
marcinbor85
approved these changes
Mar 8, 2021
| _START_RECORD byte = 5 // Record with start linear address | ||
| _DATA_RECORD byte = 0 // Record with data bytes | ||
| _EOF_RECORD byte = 1 // Record with end of file indicator | ||
| _EXTENDED_RECORD byte = 2 |
There was a problem hiding this comment.
althout this is extended record, but it differs from address record only by address size length (20 bits instead of 32).
so i suggest rename it to _ADDRESS_20_RECORD instead of _EXTENDED_RECORD. cause both are extended address in fact.
| @@ -52,7 +52,7 @@ func getExtendedAddress(bytes []byte) (adr uint32, err error) { | |||
| if binary.BigEndian.Uint16(bytes[1:3]) != 0 { | |||
| return 0, errors.New("incorrect address field in extended linear address line") | |||
| } | |||
| adr = uint32(binary.BigEndian.Uint16(bytes[4:6])) << 16 | |||
| adr = uint32(binary.BigEndian.Uint16(bytes[4:6])) << (1 << bytes[3]) | |||
There was a problem hiding this comment.
(1 << bytes[3]) is true only for record 2 (extended 20 bits). i think it isn't backward compatible. for record 4 (32 bits) what is the bytes[3] value?
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Mar 8, 2021
Since marcinbor85/gohex#2 has been merged there is no more reason to keep the fork.
cmaglie
added a commit
to arduino/arduino-cli
that referenced
this pull request
Mar 8, 2021
Since marcinbor85/gohex#2 has been merged there is no more reason to keep the fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes arduino/arduino-cli#2842 and arduino/arduino-cli#1009