Skip to content

Fixing inconsistent comments #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixing inconsistent comments #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/mplfinance/_panels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ def _build_panels( figure, config ):
------
The following items are used from `config`:

num_panels : integer (0-9) or None
num_panels : integer (0-31) or None
number of panels to create

addplot : dict or None
value for the `addplot=` kwarg passed into `mplfinance.plot()`

volume_panel : integer (0-9) or None
volume_panel : integer (0-31) or None
panel id (0-number_of_panels)

main_panel : integer (0-9) or None
main_panel : integer (0-31) or None
panel id (0-number_of_panels)

panel_ratios : sequence or None
Expand Down Expand Up @@ -68,7 +68,7 @@ def _build_panels( figure, config ):
panel_ratios = config['panel_ratios']

if not _valid_panel_id(main_panel):
raise ValueError('main_panel id must be integer 0 to 9, but is '+str(main_panel))
raise ValueError('main_panel id must be integer 0 to 31, but is '+str(main_panel))

if num_panels is None: # then infer the number of panels:
pset = {0} # start with a set including only panel zero
Expand All @@ -85,12 +85,12 @@ def _build_panels( figure, config ):
if panel in backwards_panel_compatibility:
panel = backwards_panel_compatibility[panel]
if not _valid_panel_id(panel):
raise ValueError('addplot panel must be integer 0 to 9, but is "'+str(panel)+'"')
raise ValueError('addplot panel must be integer 0 to 31, but is "'+str(panel)+'"')
pset.add(panel)

if volume is True:
if not _valid_panel_id(volume_panel):
raise ValueError('volume_panel must be integer 0 to 9, but is "'+str(volume_panel)+'"')
raise ValueError('volume_panel must be integer 0 to 31, but is "'+str(volume_panel)+'"')
pset.add(volume_panel)

pset.add(main_panel)
Expand Down