Remove unreachable memory logging code checking for dict structure #2905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `memories` variable is always a list after being processed from `hits.points`, making the `isinstance(memories, dict) and 'results' in memories` block unreachable. This commit removes the dead code path, simplifying the memory access logging logic and reducing confusion for future contributors.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unreachable legacy code that attempted to log memory access from a dict structure with a
resultskey. After the memories variable is processed into a list of dictionaries via list comprehension, it can no longer be a dict, making the conditionalisinstance(memories, dict)always false.This simplifies the control flow and avoids confusion for future contributors.
No functional behavior has changed.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Maintainer Checklist