fix: error handling - pull remote models list raise an error on fail #4615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
extensions/engine-management-extension/src/index.ts
file to rename a class and improve the handling of remote models.In the latest beta version, users will need to delete the engine and then add it back to have the /models pulled. Instead, with this update, users will only need to update the /models endpoint to trigger the models pull.
Class renaming:
extensions/engine-management-extension/src/index.ts
: RenamedJSONEngineManagementExtension
toJanEngineManagementExtension
to better reflect its functionality.Handling of remote models:
extensions/engine-management-extension/src/index.ts
: Updated theupdateEngine
method to callpopulateRemoteModels
after posting the engine configuration to ensure remote models are populated.extensions/engine-management-extension/src/index.ts
: Modified thegetRemoteModels
method to use safe navigation (?.
) when mapping models to handle cases wheredata
might be undefined.