Skip to content

fix: error handling - pull remote models list raise an error on fail #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Feb 9, 2025

This pull request includes changes to the extensions/engine-management-extension/src/index.ts file to rename a class and improve the handling of remote models.

In the latest beta version, users will need to delete the engine and then add it back to have the /models pulled. Instead, with this update, users will only need to update the /models endpoint to trigger the models pull.

Uploading CleanShot 2025-02-09 at 19.13.34@2x.jpg…

Class renaming:

Handling of remote models:

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Barecheck - Code coverage report

Total: 67.74%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-menlo louis-menlo changed the title Chore/pull models list on update models endpoint chore: pull models list on update models endpoint Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo
Copy link
Contributor Author

Another thought, it would spam default remote engines models list. On-hold for now.

@louis-menlo louis-menlo closed this Feb 9, 2025
@louis-menlo louis-menlo reopened this Feb 9, 2025
@louis-menlo louis-menlo changed the title chore: pull models list on update models endpoint fix: error handling - pull remote models list raise an error on fail Feb 9, 2025
@louis-menlo louis-menlo merged commit 45edb9c into release/v0.5.15 Feb 9, 2025
19 checks passed
@louis-menlo louis-menlo deleted the chore/pull-models-list-on-update-models-endpoint branch February 9, 2025 12:40
@github-actions github-actions bot added this to the v0.5.15 milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants