CI: run tests with MSVC too

Author: dnicolodi

.github/workflows/tests.yml

@@ -104,6 +104,44 @@ jobs:
           env_vars: PYTHON
           name: ${{ matrix.python }}
 
+  msvc:
+    runs-on: windows-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python:
+          - '3.11'
+        meson:
+          -
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Set up target Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python }}
+
+      - name: Install Ninja
+        run: python -m pip --disable-pip-version-check install ninja
+
+      - name: Setup MSVC
+        uses: bus1/cabuild/action/msdevshell@v1
+        with:
+          architecture: x64
+
+      - name: Install Meson
+        run: python -m pip --disable-pip-version-check install "meson==${{ matrix.meson }}"
+        if: ${{ matrix.meson }}
+
+      - name: Install
+        run: python -m pip --disable-pip-version-check install .[test]
+
+      - name: Run tests
+        run: >-
+          python -m pytest --showlocals -vv
+
   cygwin:
     runs-on: windows-latest
     strategy:

mesonpy/__init__.py

@@ -392,7 +392,7 @@ def top_level_modules(self) -> Collection[str]:
                             break
                     else:  # nobreak
                         # skip Windows import libraries
-                        if top_part.endswith('.a'):
+                        if top_part.endswith(('.dll.a', '.lib')):
                             continue
                         # package module
                         modules.add(top_part)
@@ -421,7 +421,7 @@ def _is_native(self, file: Union[str, pathlib.Path]) -> bool:
             return True
         return False
 
-    def _install_path(
+    def _install_path(  # noqa: C901
         self,
         wheel_file: mesonpy._wheelfile.WheelFile,
         counter: mesonpy._util.CLICounter,
@@ -476,7 +476,13 @@ def _install_path(
                             raise NotImplementedError("Bundling libraries in wheel is not supported on platform '{}'"
                                                       .format(platform.system()))
 
-            wheel_file.write(origin, location)
+            try:
+                wheel_file.write(origin, location)
+            except FileNotFoundError:
+                if os.fspath(origin).endswith('.pdb'):
+                    # work around for Meson bug
+                    pass
+                raise
 
     def _wheel_write_metadata(self, whl: mesonpy._wheelfile.WheelFile) -> None:
         # add metadata

tests/test_wheel.py

@@ -4,6 +4,7 @@
 
 import platform
 import re
+import shutil
 import stat
 import subprocess
 import sys
@@ -28,7 +29,8 @@
         from distutils.sysconfig import get_config_var
         EXT_SUFFIX = get_config_var('EXT_SUFFIX')
 
-EXT_IMP_SUFFIX = re.sub(r'.pyd$', '.dll', EXT_SUFFIX) + '.a'
+if sys.platform in {'win32', 'cygwin'}:
+    EXT_IMP_SUFFIX = re.sub(r'.(pyd|dll)$', '.lib' if shutil.which('cl.exe') else '.dll.a', EXT_SUFFIX)
 
 # Test against the wheel tag generated by packaging module.
 tag = next(packaging.tags.sys_tags())