Skip to content

Improve the performance of updateExportedFilesMapFromCache #45283

Closed
@amcasey

Description

@amcasey

#45238 mitigates performance problems in updateExportedFilesMapFromCache but doesn't address the underlying problems.

  1. Why is updateExportedFilesMapFromCache called so many times during the course of building a single projects?
  2. If not making any updates is the common case, would another representation be more appropriate (e.g. storing a delta, rather than a copy)?
  3. If we continue to update the "real" map from a full cache, can the update share code with clone? (The PR doesn't because clone appears to make a shallow copy which (a) seems wrong and (b) wasn't what the code being replaced did.)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions