Closed
Description
#45238 mitigates performance problems in updateExportedFilesMapFromCache
but doesn't address the underlying problems.
- Why is
updateExportedFilesMapFromCache
called so many times during the course of building a single projects? - If not making any updates is the common case, would another representation be more appropriate (e.g. storing a delta, rather than a copy)?
- If we continue to update the "real" map from a full cache, can the update share code with
clone
? (The PR doesn't becauseclone
appears to make a shallow copy which (a) seems wrong and (b) wasn't what the code being replaced did.)