fix moduleNameResolver cache #26296
Merged
fix moduleNameResolver cache #26296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
commented
Aug 8, 2018
| @@ -0,0 +1,28 @@ | |||
| tests/cases/compiler/monorepo/context/src/bindingkey.ts(1,29): error TS2307: Cannot find module '@loopback/context'. | |||
There was a problem hiding this comment.
By the way, the changed baseline shows a bug in the test. It always worked because of the caching bug. Now it can no longer resolve the module. Should I fix that test?
There was a problem hiding this comment.
Yes please, Can you please change import to context instead? Thanks.
There was a problem hiding this comment.
I changed the path where the symlink is located so it can be resolved now. I didn't want to change any import paths as I don't know exactly what this test does.
| originalPath: "/sub/node_modules/a/index.ts", | ||
| packageId: undefined, | ||
| resolvedFileName: "/modules/a.ts", | ||
| }); |
There was a problem hiding this comment.
Can you also add test that in file "/sub/foo.ts" "a" resolves same as this.
sheetalkamat
approved these changes
Aug 10, 2018
|
Looks good but we should wait to merge this till review comments are fixed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26271
@sheetalkamat could you please review?