Relax the constraints of isValidBaseType to allow base types to be constructor types

[weswigham]

Fixes #33127

[weswigham]

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at 07283de. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 07283de. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 07283de. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[weswigham]

User baselines are just today's as yet uncaptured/accepted update (just changes in upstream projects), so are clean~

[weswigham]

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this
@typescript-bot perf test this

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at fd6472c. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the perf test suite on this PR at fd6472c. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at fd6472c. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at fd6472c. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..33146

Metric	master	33146	Delta	Best	Worst
Angular - node (v12.1.0, x64)
Memory used	331,277k (± 0.02%)	331,516k (± 0.09%)	+240k (+ 0.07%)	330,292k	331,782k
Parse Time	1.55s (± 0.61%)	1.56s (± 0.43%)	+0.00s (+ 0.26%)	1.55s	1.58s
Bind Time	0.78s (± 0.43%)	0.78s (± 0.60%)	-0.00s (- 0.00%)	0.77s	0.79s
Check Time	4.25s (± 0.33%)	4.27s (± 0.58%)	+0.01s (+ 0.26%)	4.20s	4.32s
Emit Time	5.27s (± 1.09%)	5.25s (± 1.00%)	-0.02s (- 0.32%)	5.16s	5.42s
Total Time	11.85s (± 0.51%)	11.85s (± 0.54%)	-0.00s (- 0.01%)	11.72s	12.03s
Monaco - node (v12.1.0, x64)
Memory used	345,950k (± 0.02%)	345,957k (± 0.02%)	+8k (+ 0.00%)	345,820k	346,217k
Parse Time	1.23s (± 0.41%)	1.22s (± 0.51%)	-0.01s (- 0.49%)	1.21s	1.23s
Bind Time	0.67s (± 0.66%)	0.68s (± 1.13%)	+0.00s (+ 0.45%)	0.66s	0.69s
Check Time	4.25s (± 0.33%)	4.25s (± 0.34%)	-0.00s (- 0.09%)	4.21s	4.28s
Emit Time	2.86s (± 0.72%)	2.83s (± 0.56%)	-0.03s (- 0.94%)	2.79s	2.87s
Total Time	9.01s (± 0.17%)	8.98s (± 0.25%)	-0.03s (- 0.33%)	8.94s	9.03s
TFS - node (v12.1.0, x64)
Memory used	301,448k (± 0.02%)	301,382k (± 0.02%)	-66k (- 0.02%)	301,279k	301,502k
Parse Time	0.95s (± 0.65%)	0.95s (± 0.71%)	-0.00s (- 0.21%)	0.93s	0.96s
Bind Time	0.62s (± 0.48%)	0.62s (± 0.93%)	+0.00s (+ 0.16%)	0.61s	0.64s
Check Time	3.85s (± 0.46%)	3.84s (± 0.36%)	-0.01s (- 0.18%)	3.81s	3.87s
Emit Time	2.96s (± 1.32%)	2.94s (± 0.67%)	-0.02s (- 0.71%)	2.88s	2.97s
Total Time	8.38s (± 0.44%)	8.36s (± 0.29%)	-0.03s (- 0.31%)	8.31s	8.42s
Angular - node (v8.9.0, x64)
Memory used	350,147k (± 0.02%)	350,509k (± 0.02%)	+362k (+ 0.10%)	350,397k	350,657k
Parse Time	2.10s (± 0.47%)	2.10s (± 0.36%)	-0.00s (- 0.24%)	2.07s	2.11s
Bind Time	0.83s (± 0.48%)	0.83s (± 0.57%)	+0.00s (+ 0.12%)	0.82s	0.84s
Check Time	5.10s (± 0.43%)	5.11s (± 0.70%)	+0.01s (+ 0.24%)	5.05s	5.21s
Emit Time	5.98s (± 0.91%)	5.93s (± 0.64%)	-0.06s (- 0.97%)	5.85s	6.01s
Total Time	14.02s (± 0.41%)	13.97s (± 0.40%)	-0.05s (- 0.37%)	13.85s	14.07s
Monaco - node (v8.9.0, x64)
Memory used	363,726k (± 0.01%)	363,701k (± 0.01%)	-26k (- 0.01%)	363,594k	363,809k
Parse Time	1.56s (± 0.48%)	1.56s (± 0.52%)	-0.00s (- 0.06%)	1.55s	1.58s
Bind Time	0.88s (± 0.70%)	0.89s (± 0.56%)	+0.01s (+ 0.68%)	0.88s	0.90s
Check Time	5.15s (± 1.43%)	5.10s (± 1.44%)	-0.05s (- 1.07%)	4.99s	5.25s
Emit Time	3.05s (± 4.26%)	3.17s (± 4.88%)	+0.11s (+ 3.74%)	2.85s	3.36s
Total Time	10.64s (± 0.62%)	10.71s (± 0.85%)	+0.07s (+ 0.62%)	10.51s	10.83s
TFS - node (v8.9.0, x64)
Memory used	317,662k (± 0.02%)	317,690k (± 0.02%)	+27k (+ 0.01%)	317,596k	317,782k
Parse Time	1.26s (± 0.60%)	1.26s (± 0.35%)	+0.00s (+ 0.16%)	1.25s	1.27s
Bind Time	0.68s (± 4.63%)	0.71s (± 6.57%)	+0.03s (+ 4.09%)	0.66s	0.80s
Check Time	4.44s (± 1.09%)	4.41s (± 1.13%)	-0.04s (- 0.81%)	4.30s	4.49s
Emit Time	3.06s (± 0.38%)	3.07s (± 0.50%)	+0.01s (+ 0.20%)	3.04s	3.10s
Total Time	9.45s (± 0.27%)	9.45s (± 0.21%)	-0.00s (- 0.04%)	9.41s	9.49s
Angular - node (v8.9.0, x86)
Memory used	198,202k (± 0.02%)	198,351k (± 0.02%)	+148k (+ 0.07%)	198,270k	198,480k
Parse Time	2.04s (± 0.57%)	2.04s (± 0.65%)	-0.00s (- 0.10%)	2.01s	2.07s
Bind Time	0.95s (± 0.38%)	0.95s (± 0.52%)	0.00s ( 0.00%)	0.94s	0.96s
Check Time	4.64s (± 0.41%)	4.63s (± 0.30%)	-0.00s (- 0.09%)	4.60s	4.67s
Emit Time	5.69s (± 1.37%)	5.63s (± 0.74%)	-0.06s (- 1.02%)	5.56s	5.74s
Total Time	13.31s (± 0.63%)	13.25s (± 0.38%)	-0.06s (- 0.49%)	13.12s	13.38s
Monaco - node (v8.9.0, x86)
Memory used	203,245k (± 0.02%)	203,240k (± 0.02%)	-5k (- 0.00%)	203,144k	203,302k
Parse Time	1.61s (± 0.68%)	1.62s (± 0.79%)	+0.00s (+ 0.31%)	1.60s	1.66s
Bind Time	0.72s (± 0.66%)	0.72s (± 0.83%)	-0.00s (- 0.14%)	0.71s	0.73s
Check Time	4.89s (± 0.41%)	4.87s (± 0.41%)	-0.02s (- 0.37%)	4.82s	4.93s
Emit Time	3.19s (± 0.76%)	3.16s (± 1.11%)	-0.03s (- 0.78%)	3.05s	3.24s
Total Time	10.41s (± 0.43%)	10.37s (± 0.27%)	-0.04s (- 0.40%)	10.31s	10.43s
TFS - node (v8.9.0, x86)
Memory used	178,569k (± 0.01%)	178,560k (± 0.02%)	-10k (- 0.01%)	178,491k	178,685k
Parse Time	1.31s (± 0.68%)	1.31s (± 0.63%)	-0.01s (- 0.61%)	1.29s	1.33s
Bind Time	0.64s (± 1.05%)	0.64s (± 1.05%)	+0.00s (+ 0.00%)	0.63s	0.66s
Check Time	4.29s (± 0.76%)	4.27s (± 0.62%)	-0.02s (- 0.40%)	4.22s	4.32s
Emit Time	2.86s (± 0.61%)	2.85s (± 1.04%)	-0.01s (- 0.49%)	2.76s	2.92s
Total Time	9.10s (± 0.40%)	9.06s (± 0.41%)	-0.04s (- 0.43%)	8.98s	9.13s
Angular - node (v9.0.0, x64)
Memory used	349,793k (± 0.01%)	350,160k (± 0.01%)	+367k (+ 0.11%)	350,036k	350,242k
Parse Time	1.82s (± 0.33%)	1.82s (± 0.42%)	-0.00s (- 0.06%)	1.80s	1.83s
Bind Time	0.77s (± 0.62%)	0.77s (± 0.44%)	0.00s ( 0.00%)	0.77s	0.78s
Check Time	4.84s (± 0.43%)	4.84s (± 0.31%)	-0.00s (- 0.08%)	4.81s	4.88s
Emit Time	5.74s (± 1.28%)	5.79s (± 0.95%)	+0.05s (+ 0.82%)	5.64s	5.88s
Total Time	13.17s (± 0.58%)	13.22s (± 0.47%)	+0.05s (+ 0.36%)	13.06s	13.35s
Monaco - node (v9.0.0, x64)
Memory used	363,515k (± 0.02%)	363,480k (± 0.03%)	-35k (- 0.01%)	363,360k	363,731k
Parse Time	1.32s (± 0.52%)	1.31s (± 0.36%)	-0.01s (- 0.46%)	1.30s	1.32s
Bind Time	0.82s (± 0.89%)	0.84s (± 1.13%)	+0.01s (+ 1.82%)	0.82s	0.85s
Check Time	5.09s (± 1.15%)	4.97s (± 1.76%)	-0.11s (- 2.22%)	4.85s	5.15s
Emit Time	2.97s (± 4.82%)	3.16s (± 5.58%)	+0.19s (+ 6.41%)	2.85s	3.40s
Total Time	10.19s (± 1.02%)	10.28s (± 1.01%)	+0.08s (+ 0.82%)	10.06s	10.44s
TFS - node (v9.0.0, x64)
Memory used	317,477k (± 0.01%)	317,456k (± 0.02%)	-21k (- 0.01%)	317,351k	317,541k
Parse Time	1.04s (± 0.70%)	1.04s (± 0.87%)	+0.00s (+ 0.10%)	1.02s	1.07s
Bind Time	0.62s (± 0.36%)	0.62s (± 0.99%)	+0.00s (+ 0.32%)	0.61s	0.63s
Check Time	4.35s (± 0.37%)	4.38s (± 0.41%)	+0.02s (+ 0.46%)	4.34s	4.42s
Emit Time	3.19s (± 0.39%)	3.18s (± 0.78%)	-0.01s (- 0.41%)	3.10s	3.23s
Total Time	9.21s (± 0.26%)	9.22s (± 0.44%)	+0.01s (+ 0.09%)	9.11s	9.32s
Angular - node (v9.0.0, x86)
Memory used	198,395k (± 0.03%)	198,524k (± 0.02%)	+128k (+ 0.06%)	198,453k	198,622k
Parse Time	1.72s (± 0.51%)	1.73s (± 0.87%)	+0.01s (+ 0.35%)	1.70s	1.77s
Bind Time	0.90s (± 1.04%)	0.89s (± 0.58%)	-0.01s (- 1.00%)	0.88s	0.90s
Check Time	4.33s (± 0.54%)	4.34s (± 0.30%)	+0.01s (+ 0.25%)	4.31s	4.37s
Emit Time	5.49s (± 0.55%)	5.51s (± 0.98%)	+0.02s (+ 0.46%)	5.44s	5.70s
Total Time	12.44s (± 0.40%)	12.47s (± 0.50%)	+0.03s (+ 0.25%)	12.38s	12.68s
Monaco - node (v9.0.0, x86)
Memory used	203,360k (± 0.01%)	203,330k (± 0.03%)	-30k (- 0.01%)	203,161k	203,429k
Parse Time	1.34s (± 0.76%)	1.34s (± 0.43%)	+0.00s (+ 0.07%)	1.33s	1.36s
Bind Time	0.65s (± 0.77%)	0.65s (± 1.56%)	+0.00s (+ 0.16%)	0.63s	0.68s
Check Time	4.69s (± 0.47%)	4.69s (± 0.65%)	+0.01s (+ 0.15%)	4.64s	4.78s
Emit Time	3.08s (± 0.61%)	3.08s (± 0.45%)	+0.00s (+ 0.10%)	3.05s	3.12s
Total Time	9.75s (± 0.32%)	9.76s (± 0.34%)	+0.01s (+ 0.11%)	9.68s	9.82s
TFS - node (v9.0.0, x86)
Memory used	178,614k (± 0.02%)	178,629k (± 0.02%)	+15k (+ 0.01%)	178,557k	178,709k
Parse Time	1.07s (± 1.05%)	1.06s (± 1.26%)	-0.00s (- 0.09%)	1.05s	1.11s
Bind Time	0.57s (± 0.52%)	0.58s (± 0.82%)	+0.01s (+ 0.87%)	0.57s	0.59s
Check Time	4.14s (± 0.62%)	4.12s (± 0.34%)	-0.02s (- 0.48%)	4.10s	4.16s
Emit Time	2.77s (± 1.05%)	2.79s (± 1.02%)	+0.01s (+ 0.47%)	2.71s	2.87s
Total Time	8.56s (± 0.65%)	8.55s (± 0.39%)	-0.00s (- 0.02%)	8.46s	8.63s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-161-generic
Architecture	x64
Available Memory	16 GB
Available Memory	9 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)
• node (v9.0.0, x64)
• node (v9.0.0, x86)

Scenarios

• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Angular - node (v9.0.0, x64)
• Angular - node (v9.0.0, x86)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• Monaco - node (v9.0.0, x64)
• Monaco - node (v9.0.0, x86)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)
• TFS - node (v9.0.0, x64)
• TFS - node (v9.0.0, x86)

Benchmark	Name	Iterations
Current	33146	10
Baseline	master	10

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.