Skip to content

factory: parenthesize for-of expression when necessary #34229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

factory: parenthesize for-of expression when necessary #34229

merged 1 commit into from
Oct 17, 2019

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Oct 13, 2019

Fixes: #33856

@falsandtru
Copy link
Contributor

@RyanCavanaugh Can you merge this too?

@falsandtru
Copy link
Contributor

falsandtru commented Oct 17, 2019 •
edited
Loading

@rbuckton A PR for an issue you are assigned has made.

@RyanCavanaugh RyanCavanaugh merged commit 45d0ef9 into microsoft:master Oct 17, 2019
@RyanCavanaugh
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error in emit when using nullish coalescing and optional chaining in for-of operand
4 participants
@ajafff @falsandtru @RyanCavanaugh @sheetalkamat