Skip to content

Assignment operator is definite assignment #39087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jun 16, 2020

Fixes #39088

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 16, 2020

@aminpaks Fix available here.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 16, 2020

@typescript-bot pack this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 16, 2020

Heya @Kingwl, I've started to run the tarball bundle task on this PR at fdf8d26. You can monitor the build here.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 16, 2020

Ci is broken, but not my fault.

@orta
Copy link
Contributor

orta commented Jun 16, 2020

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 16, 2020

Heya @orta, I've started to run the tarball bundle task on this PR at 56e134a. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

What exactly is the difference? Does a definite assignment widen to the base primitive type?

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 16, 2020

What exactly is the difference? Does a definite assignment widen to the base primitive type?

Basically yes.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 16, 2020

Hey @orta, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/76651/artifacts?artifactName=tgz&fileId=5E1BAC44463C97C5571055CEDF41DB1432950FFAC33ED05242F977BB210D224A02&fileName=/typescript-4.0.0-insiders.20200616.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@orta
Copy link
Contributor

orta commented Jun 16, 2020

Confirmed the fix in the playground, looks good to me 👍

@orta orta merged commit 6c11ceb into microsoft:master Jun 16, 2020
@Kingwl Kingwl deleted the assignment_operator_assignment_kind branch June 17, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical Assignment Operator should be a definite assignment kind
4 participants