Skip to content

Fix39458 #39508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2020
Merged

Fix39458 #39508

merged 3 commits into from
Jul 9, 2020

Conversation

jessetrinity
Copy link
Contributor

Adds a new NodeBuilderFlag to remove undefined from the type of optional parameters in symbolToParameterDeclaration.

Fixes #39458

@jessetrinity jessetrinity requested a review from weswigham July 8, 2020 21:57
weswigham
weswigham reviewed Jul 8, 2020
View reviewed changes
@jessetrinity jessetrinity requested a review from weswigham July 9, 2020 17:42
@jessetrinity jessetrinity merged commit 8e9de9b into microsoft:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement interface adds an extra | undefined to parameter
2 participants
@jessetrinity @weswigham