-
Notifications
You must be signed in to change notification settings - Fork 12.9k
transformGenerators
: handle CommaListExpression
#41079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131 changes: 131 additions & 0 deletions
131
tests/baselines/reference/es5-asyncFunctionLongObjectLiteral.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
//// [es5-asyncFunctionLongObjectLiteral.ts] | ||
// the generated code from both should be similar | ||
|
||
const fooShort = async () => { | ||
return { | ||
a: await Promise.resolve(0), | ||
b: await Promise.resolve(1), | ||
c: await Promise.resolve(2), | ||
d: await Promise.resolve(3), | ||
e: await Promise.resolve(4), | ||
}; | ||
} | ||
|
||
const fooLong = async () => { | ||
return { | ||
a: await Promise.resolve(0), | ||
b: await Promise.resolve(1), | ||
c: await Promise.resolve(2), | ||
d: await Promise.resolve(3), | ||
e: await Promise.resolve(4), | ||
f: await Promise.resolve(5), | ||
g: await Promise.resolve(6), | ||
h: await Promise.resolve(7), | ||
i: await Promise.resolve(8), | ||
j: await Promise.resolve(9), | ||
}; | ||
} | ||
|
||
|
||
//// [es5-asyncFunctionLongObjectLiteral.js] | ||
// the generated code from both should be similar | ||
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) { | ||
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); } | ||
return new (P || (P = Promise))(function (resolve, reject) { | ||
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } } | ||
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } } | ||
function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); } | ||
step((generator = generator.apply(thisArg, _arguments || [])).next()); | ||
}); | ||
}; | ||
var __generator = (this && this.__generator) || function (thisArg, body) { | ||
var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g; | ||
return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g; | ||
function verb(n) { return function (v) { return step([n, v]); }; } | ||
function step(op) { | ||
if (f) throw new TypeError("Generator is already executing."); | ||
while (_) try { | ||
if (f = 1, y && (t = op[0] & 2 ? y["return"] : op[0] ? y["throw"] || ((t = y["return"]) && t.call(y), 0) : y.next) && !(t = t.call(y, op[1])).done) return t; | ||
if (y = 0, t) op = [op[0] & 2, t.value]; | ||
switch (op[0]) { | ||
case 0: case 1: t = op; break; | ||
case 4: _.label++; return { value: op[1], done: false }; | ||
case 5: _.label++; y = op[1]; op = [0]; continue; | ||
case 7: op = _.ops.pop(); _.trys.pop(); continue; | ||
default: | ||
if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) { _ = 0; continue; } | ||
if (op[0] === 3 && (!t || (op[1] > t[0] && op[1] < t[3]))) { _.label = op[1]; break; } | ||
if (op[0] === 6 && _.label < t[1]) { _.label = t[1]; t = op; break; } | ||
if (t && _.label < t[2]) { _.label = t[2]; _.ops.push(op); break; } | ||
if (t[2]) _.ops.pop(); | ||
_.trys.pop(); continue; | ||
} | ||
op = body.call(thisArg, _); | ||
} catch (e) { op = [6, e]; y = 0; } finally { f = t = 0; } | ||
if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true }; | ||
} | ||
}; | ||
var _this = this; | ||
var fooShort = function () { return __awaiter(_this, void 0, void 0, function () { | ||
var _a; | ||
return __generator(this, function (_b) { | ||
switch (_b.label) { | ||
case 0: | ||
_a = {}; | ||
return [4 /*yield*/, Promise.resolve(0)]; | ||
case 1: | ||
_a.a = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(1)]; | ||
case 2: | ||
_a.b = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(2)]; | ||
case 3: | ||
_a.c = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(3)]; | ||
case 4: | ||
_a.d = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(4)]; | ||
case 5: return [2 /*return*/, (_a.e = _b.sent(), | ||
_a)]; | ||
} | ||
}); | ||
}); }; | ||
var fooLong = function () { return __awaiter(_this, void 0, void 0, function () { | ||
var _a; | ||
return __generator(this, function (_b) { | ||
switch (_b.label) { | ||
case 0: | ||
_a = {}; | ||
return [4 /*yield*/, Promise.resolve(0)]; | ||
case 1: | ||
_a.a = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(1)]; | ||
case 2: | ||
_a.b = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(2)]; | ||
case 3: | ||
_a.c = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(3)]; | ||
case 4: | ||
_a.d = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(4)]; | ||
case 5: | ||
_a.e = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(5)]; | ||
case 6: | ||
_a.f = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(6)]; | ||
case 7: | ||
_a.g = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(7)]; | ||
case 8: | ||
_a.h = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(8)]; | ||
case 9: | ||
_a.i = _b.sent(); | ||
return [4 /*yield*/, Promise.resolve(9)]; | ||
case 10: return [2 /*return*/, (_a.j = _b.sent(), | ||
_a)]; | ||
} | ||
}); | ||
}); }; |
107 changes: 107 additions & 0 deletions
107
tests/baselines/reference/es5-asyncFunctionLongObjectLiteral.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
=== tests/cases/compiler/es5-asyncFunctionLongObjectLiteral.ts === | ||
// the generated code from both should be similar | ||
|
||
const fooShort = async () => { | ||
>fooShort : Symbol(fooShort, Decl(es5-asyncFunctionLongObjectLiteral.ts, 2, 5)) | ||
|
||
return { | ||
a: await Promise.resolve(0), | ||
>a : Symbol(a, Decl(es5-asyncFunctionLongObjectLiteral.ts, 3, 12)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
b: await Promise.resolve(1), | ||
>b : Symbol(b, Decl(es5-asyncFunctionLongObjectLiteral.ts, 4, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
c: await Promise.resolve(2), | ||
>c : Symbol(c, Decl(es5-asyncFunctionLongObjectLiteral.ts, 5, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
d: await Promise.resolve(3), | ||
>d : Symbol(d, Decl(es5-asyncFunctionLongObjectLiteral.ts, 6, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
e: await Promise.resolve(4), | ||
>e : Symbol(e, Decl(es5-asyncFunctionLongObjectLiteral.ts, 7, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
}; | ||
} | ||
|
||
const fooLong = async () => { | ||
>fooLong : Symbol(fooLong, Decl(es5-asyncFunctionLongObjectLiteral.ts, 12, 5)) | ||
|
||
return { | ||
a: await Promise.resolve(0), | ||
>a : Symbol(a, Decl(es5-asyncFunctionLongObjectLiteral.ts, 13, 12)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
b: await Promise.resolve(1), | ||
>b : Symbol(b, Decl(es5-asyncFunctionLongObjectLiteral.ts, 14, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
c: await Promise.resolve(2), | ||
>c : Symbol(c, Decl(es5-asyncFunctionLongObjectLiteral.ts, 15, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
d: await Promise.resolve(3), | ||
>d : Symbol(d, Decl(es5-asyncFunctionLongObjectLiteral.ts, 16, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
e: await Promise.resolve(4), | ||
>e : Symbol(e, Decl(es5-asyncFunctionLongObjectLiteral.ts, 17, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
f: await Promise.resolve(5), | ||
>f : Symbol(f, Decl(es5-asyncFunctionLongObjectLiteral.ts, 18, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
g: await Promise.resolve(6), | ||
>g : Symbol(g, Decl(es5-asyncFunctionLongObjectLiteral.ts, 19, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
h: await Promise.resolve(7), | ||
>h : Symbol(h, Decl(es5-asyncFunctionLongObjectLiteral.ts, 20, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
i: await Promise.resolve(8), | ||
>i : Symbol(i, Decl(es5-asyncFunctionLongObjectLiteral.ts, 21, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
j: await Promise.resolve(9), | ||
>j : Symbol(j, Decl(es5-asyncFunctionLongObjectLiteral.ts, 22, 36)) | ||
>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --)) | ||
|
||
}; | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.