Skip to content

Forbid duplicates in baselines #44652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Forbid duplicates in baselines #44652

merged 2 commits into from
Jun 18, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jun 18, 2021

The check is case insensitive.

Note that this does not run with gulp runtests-parallel, meaning that

  1. people who only run all the tests at once won't see the failure.
  2. the failure won't block CI.

(1) is a real drawback, though not a big one, and (2) is in my opinion positive, though also small. The failure message is clear enough that the person who first encounters it should be able to fix the problem.

The check is case insensitive.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 18, 2021
Gotta have those semicolons.
@sandersn sandersn merged commit 0f216f3 into main Jun 18, 2021
@sandersn sandersn deleted the forbid-dupes-in-baselines branch June 18, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants