Skip to content

Improve parsing in await and yield context #44680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jun 21, 2021

Fixes #44459
Close #44464 for case sensitive issue.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 21, 2021

Try deleting it from isIdentifier

You can see this commit. Seems not feel better.
It is worth noting that the emitted code has changed. So it's might a breaking change.

If that doesn't work out, put a small comment

Done.

@sandersn sandersn merged commit fafe3ff into microsoft:main Jun 22, 2021
@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 22, 2021

@typescript-bot pack this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 22, 2021

Heya @Kingwl, I've started to run the tarball bundle task on this PR at 23cd5e9. You can monitor the build here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding identifier should care about await/yield context
3 participants