Fix import statement completions for export= in JS files #45128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
Jul 20, 2021
| const suffix = useSemicolons ? ";" : ""; | ||
| switch (importKind) { | ||
| case ImportKind.CommonJS: return { replacementSpan, insertText: `import ${name}${tabStop} = require(${quotedModuleSpecifier})${suffix}` }; | ||
| case ImportKind.Default: return { replacementSpan, insertText: `import ${name}${tabStop} from ${quotedModuleSpecifier}${suffix}` }; | ||
| case ImportKind.Namespace: return { replacementSpan, insertText: `import * as ${name}${tabStop} from ${quotedModuleSpecifier}${suffix}` }; | ||
| case ImportKind.Namespace: return { replacementSpan, insertText: `import * as ${name} from ${quotedModuleSpecifier}${suffix}` }; |
There was a problem hiding this comment.
Drive by fix: tabstop is unnecessary in this snippet because you can’t add a comma and import more things after import * as whatever
DanielRosenwasser
approved these changes
Jul 28, 2021
Comment on lines
+568
to
+569
| * @param forceImportKeyword Indicates that the user has already typed `import`, so the result must start with `import`. | ||
| * (In other words, do not allow `const x = require("...")` for JS files.) |
There was a problem hiding this comment.
Suggested change
| * @param forceImportKeyword Indicates that the user has already typed `import`, so the result must start with `import`. | |
| * (In other words, do not allow `const x = require("...")` for JS files.) | |
| * @param forceImportKeyword Indicates that the user has already typed `import`, so the result must start with `import`. | |
| * For example, we should not provide `const x = require("...")` for JS files if it is clear that a user is writing an `import`. |
There was a problem hiding this comment.
I would apply this except it has a bunch of leading spaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44830