Skip to content

Remove vestigial baselines #45916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Remove vestigial baselines #45916

merged 3 commits into from
Sep 16, 2021

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Sep 16, 2021

These baselines are leftovers and can be removed?

  • gulp runtests doesn't recreate them.
  • The tests all pass without them.

What I did was:

  • Add git rm -r --quiet tests/baselines/reference :^tests/baselines/reference/docker :^tests/baselines/reference/user -> .github/workflows/accept-baselines-fix-lints.yaml
  • Run that workflow to remove any unused baselines.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 16, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I knew there must be a good number of these. Your git skills are better than mine 😁

@jablko
Copy link
Contributor Author

jablko commented Sep 16, 2021

Thanks!

@andrewbranch andrewbranch merged commit 6aaefe4 into microsoft:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants