fix(47024):fix type of DateTimeFormat and NumberFormat #47117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-bot
added
For Uncommitted Bug
saschanaz
reviewed
Dec 13, 2021
| @@ -16,9 +21,4 @@ declare namespace Intl { | |||
| dayPeriod?: "narrow" | "short" | "long"; | |||
| fractionalSecondDigits?: 0 | 1 | 2 | 3; | |||
| } | |||
|
|
|||
| interface NumberFormat { | |||
There was a problem hiding this comment.
Could you perhaps move this to esnext.intl.d.ts?
There was a problem hiding this comment.
Thanks for the review!
I've fixed it.
islandryu
changed the title
islandryu
changed the title
sandersn
requested changes
Feb 7, 2022
There was a problem hiding this comment.
Looks good except the parameter names. I took a long time to review this -- @islandryu I can add my suggestion myself if you want. I'm going to hold this until 4.7 anyway since we're nearly through the 4.6 beta period.
Co-authored-by: Nathan Shively-Sanders <[email protected]>
|
@sandersn |
sandersn
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47024