Skip to content

Freeze Template Objects in __makeTemplateObject #51806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Freeze Template Objects in __makeTemplateObject #51806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c00001
Have `__makeTemplateObject` freeze template strings objects if possible.
DanielRosenwasser Dec 7, 2022
bef1da1
Update Baselines and/or Applied Lint Fixes
typescript-bot Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/compiler/factory/emitHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,12 @@ export const templateObjectHelper: UnscopedEmitHelper = {
priority: 0,
text: `
var __makeTemplateObject = (this && this.__makeTemplateObject) || function (cooked, raw) {
if (Object.defineProperty) { Object.defineProperty(cooked, "raw", { value: raw }); } else { cooked.raw = raw; }
if (Object.freeze) {
Object.freeze(Object.defineProperty(cooked, "raw", { value: Object.freeze(raw) }));
}
else {
cooked.raw = raw;
}
return cooked;
};`
};
Expand Down
21 changes: 0 additions & 21 deletions tests/baselines/reference/NonNullableInNonStrictMode.js
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions tests/baselines/reference/NonNullableInNonStrictMode.symbols
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions tests/baselines/reference/NonNullableInNonStrictMode.types
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion tests/baselines/reference/asOperator3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ var h = tag `Hello` as string;

//// [asOperator3.js]
var __makeTemplateObject = (this && this.__makeTemplateObject) || function (cooked, raw) {
if (Object.defineProperty) { Object.defineProperty(cooked, "raw", { value: raw }); } else { cooked.raw = raw; }
if (Object.freeze) {
Object.freeze(Object.defineProperty(cooked, "raw", { value: Object.freeze(raw) }));
}
else {
cooked.raw = raw;
}
return cooked;
};
var a = "".concat(123 + 456);
Expand Down
7 changes: 6 additions & 1 deletion tests/baselines/reference/asOperatorASI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ as(Foo); // should emit

//// [asOperatorASI.js]
var __makeTemplateObject = (this && this.__makeTemplateObject) || function (cooked, raw) {
if (Object.defineProperty) { Object.defineProperty(cooked, "raw", { value: raw }); } else { cooked.raw = raw; }
if (Object.freeze) {
Object.freeze(Object.defineProperty(cooked, "raw", { value: Object.freeze(raw) }));
}
else {
cooked.raw = raw;
}
return cooked;
};
var Foo = /** @class */ (function () {
Expand Down
116 changes: 0 additions & 116 deletions tests/baselines/reference/cancellationWhenfindingAllRefsOnDefinition.3.baseline.jsonc
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion tests/baselines/reference/doYouNeedToChangeYourTargetLibraryES2015.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ const testRegExpUnicode = /abc/g.unicode;

//// [doYouNeedToChangeYourTargetLibraryES2015.js]
var __makeTemplateObject = (this && this.__makeTemplateObject) || function (cooked, raw) {
if (Object.defineProperty) { Object.defineProperty(cooked, "raw", { value: raw }); } else { cooked.raw = raw; }
if (Object.freeze) {
Object.freeze(Object.defineProperty(cooked, "raw", { value: Object.freeze(raw) }));
}
else {
cooked.raw = raw;
}
return cooked;
};
// es2015
Expand Down
Loading