Skip to content

fix(54155): "Move to file" does not carry all function overload and implementation signatures #54164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2023
Merged

fix(54155): "Move to file" does not carry all function overload and implementation signatures #54164

merged 2 commits into from
May 24, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #54155

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label May 6, 2023
navya9singh
navya9singh reviewed May 8, 2023
View reviewed changes
Copy link
Member

@navya9singh navya9singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Can you also add tests to verify that this change works for moveToFile as well and not just moveToNewFile?

@a-tarasyuk
Copy link
Contributor Author

@navya9singh Sure. I've added additional tests

@a-tarasyuk a-tarasyuk requested a review from navya9singh May 8, 2023 20:31
@sandersn
Copy link
Member

@navya9singh this looks ready to me, let me know if you agree.

@sandersn sandersn merged commit 8ea3887 into microsoft:main May 24, 2023
@a-tarasyuk a-tarasyuk mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@navya9singh navya9singh navya9singh approved these changes

Assignees

@navya9singh navya9singh

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Move to file" does not carry all function overload and implementation signatures
4 participants
@a-tarasyuk @sandersn @navya9singh @typescript-bot