Skip to content

Prevent ObjectFlags.IdenticalBaseTypeExists and ObjectFlags.IsConstrainedTypeVariable confusion #56711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Dec 8, 2023

fixes #56688

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 8, 2023
@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 11, 2023
@Andarist
Copy link
Contributor Author

I managed to add a test case for this so the PR is ready for a full review :)

@Andarist Andarist requested a review from jakebailey December 11, 2023 08:58
@jakebailey jakebailey merged commit 5b10466 into microsoft:main Dec 11, 2023
@Andarist Andarist deleted the fix/remove-constrained-type-variables-crash branch December 11, 2023 18:27
c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on 5.4.0-dev.20231206
3 participants