fix: filtering promise properties in object literal completion

src/compiler/checker.ts

@@ -1637,6 +1637,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         getParameterIdentifierInfoAtPosition,
         getPromisedTypeOfPromise,
         getAwaitedType: type => getAwaitedType(type),
+        getAwaitedTypeOfPromise: type => getAwaitedTypeOfPromise(type),
         getReturnTypeOfSignature,
         isNullableType,
         getNullableType,
@@ -1861,6 +1862,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             const node = getParseTreeNode(nodeIn);
             return node && tryGetThisTypeAt(node, includeGlobalThis, container);
         },
+        filterType,
         getTypeArgumentConstraint: nodeIn => {
             const node = getParseTreeNode(nodeIn, isTypeNode);
             return node && getTypeArgumentConstraint(node);

src/compiler/types.ts

@@ -4973,6 +4973,7 @@ export interface TypeChecker {
     getPromisedTypeOfPromise(promise: Type, errorNode?: Node): Type | undefined;
     /** @internal */
     getAwaitedType(type: Type): Type | undefined;
+    getAwaitedTypeOfPromise(type: Type): Type | undefined;
     /** @internal */
     isEmptyAnonymousObjectType(type: Type): boolean;
     getReturnTypeOfSignature(signature: Signature): Type;
@@ -5288,6 +5289,8 @@ export interface TypeChecker {
     tryGetThisTypeAt(node: Node, includeGlobalThis?: boolean, container?: ThisContainer): Type | undefined;
     /** @internal */ getTypeArgumentConstraint(node: TypeNode): Type | undefined;
 
+    filterType(type: Type, f: (t: Type) => boolean): Type;
+
     /**
      * Does *not* get *all* suggestion diagnostics, just the ones that were convenient to report in the checker.
      * Others are added in computeSuggestionDiagnostics.

src/services/completions.ts

@@ -5472,9 +5472,10 @@ function getJsDocTagAtPosition(node: Node, position: number): JSDocTag | undefin
 /** @internal */
 export function getPropertiesForObjectExpression(contextualType: Type, completionsType: Type | undefined, obj: ObjectLiteralExpression | JsxAttributes, checker: TypeChecker): Symbol[] {
     const hasCompletionsType = completionsType && completionsType !== contextualType;
+    const promiseFilteredContextualType = checker.filterType(contextualType, t => !checker.getAwaitedTypeOfPromise(t));
     const type = hasCompletionsType && !(completionsType.flags & TypeFlags.AnyOrUnknown)
-        ? checker.getUnionType([contextualType, completionsType])
-        : contextualType;
+        ? checker.getUnionType([promiseFilteredContextualType, completionsType])
+        : promiseFilteredContextualType;
 
     const properties = getApparentProperties(type, obj, checker);
     return type.isClass() && containsNonPublicProperties(properties) ? [] :

tests/baselines/reference/api/typescript.d.ts

@@ -6070,6 +6070,7 @@ declare namespace ts {
         getBaseTypes(type: InterfaceType): BaseType[];
         getBaseTypeOfLiteralType(type: Type): Type;
         getWidenedType(type: Type): Type;
+        getAwaitedTypeOfPromise(type: Type): Type | undefined;
         getReturnTypeOfSignature(signature: Signature): Type;
         getNullableType(type: Type, flags: TypeFlags): Type;
         getNonNullableType(type: Type): Type;
@@ -6217,6 +6218,7 @@ declare namespace ts {
         isArrayLikeType(type: Type): boolean;
         resolveName(name: string, location: Node | undefined, meaning: SymbolFlags, excludeGlobals: boolean): Symbol | undefined;
         getTypePredicateOfSignature(signature: Signature): TypePredicate | undefined;
+        filterType(type: Type, f: (t: Type) => boolean): Type;
         /**
          * Depending on the operation performed, it may be appropriate to throw away the checker
          * if the cancellation token is triggered. Typically, if it is used for error checking

tests/cases/fourslash/completionsPropertiesWithPromiseUnionType.ts

@@ -0,0 +1,24 @@
+/// <reference path="fourslash.ts" />
+// @strict: true
+
+//// type MyType = {
+////   foo: string;
+//// };
+
+//// function fakeTest(cb: () => MyType | Promise<MyType>) {}
+
+//// fakeTest(() => {
+////   return {
+////     /*a*/
+////   };
+//// });
+
+
+verify.completions(
+  {
+    marker: ['a'],
+    exact: [
+      { name: 'foo', kind: 'property' },
+    ]
+  }
+);