Set maxNodeModuleJsDepth in JS-containing projects #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for setting a maximum depth for Node.js modules in projects that contain JavaScript files. Key changes include:
- Introducing a new field (rootJSFileCount) to track the count of JS files.
- Updating project configuration in updateProgram() to set a default MaxNodeModuleJsDepth when JS files are present.
- Refactoring root file management by replacing direct map access with helper methods that update the JS file count.
sheetalkamat
requested changes
Jun 19, 2025
internal/project/project.go
Outdated
| func (p *Project) setRootFileNameOfInferred(path tspath.Path, fileName string) { | ||
| has := p.rootFileNames.Has(path) | ||
| p.rootFileNames.Set(path, fileName) | ||
| if p.kind == KindInferred { |
There was a problem hiding this comment.
I feel like I should at least assert it for these functions? There's no guards elsewhere.
sheetalkamat
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could use a test, but this looks correct to me in theory.
Fixes #1209