Skip to content

Add patch for enabling new TS plugins on web approach #149186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented May 10, 2022

microsoft/TypeScript#47377

To run plugins on web, we need to shim out dynamicImport. This is done in a file call dynamicImportCompat.js, which is added by the linked PR

Fixes #140455

@mjbvz mjbvz self-assigned this May 10, 2022
mjbvz added 2 commits August 2, 2022 10:45
microsoft/TypeScript#47377

To run plugins on web, we need to shim out `dynamicImport`. This is done in a file call `tsserverWeb.js`, which is added by the linked PR
@mjbvz mjbvz marked this pull request as ready for review August 2, 2022 17:46
@mjbvz mjbvz force-pushed the patch-tsserver-web branch from 250435b to 0e2d10e Compare August 2, 2022 17:46
@mjbvz mjbvz added this to the August 2022 milestone Aug 2, 2022
@mjbvz mjbvz enabled auto-merge (squash) August 2, 2022 17:49
@mjbvz mjbvz merged commit 424fe15 into microsoft:main Aug 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore enabling TS Server plugins on serverless
2 participants