Skip to content

[MAINT, MRG] Fix nilearn intersphinx #10825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Conversation

alexrockhill
Copy link
Contributor

Fixes warning causing CIs to fail in #10824.

@alexrockhill
Copy link
Contributor Author

I was editing the wrong configuration file in the main mne module and not in docs this should fix it now.

@alexrockhill
Copy link
Contributor Author

It looks like this fixed the warning but nilearn's intersphinx obj is timing out... It was doing that intermittently locally.

@alexrockhill
Copy link
Contributor Author

Turns out it wasn't intermittent, they just moved to a stable/latest structure.

@drammock
Copy link
Member

rather than ignoring the warning, it would be better to fix this upstream. See, e.g.

for examples

@alexrockhill
Copy link
Contributor Author

Huh the job was abandoned at 98% complete. Okay, @drammock, I'm removing the warning filters and I'll write a PR over there.

@alexrockhill alexrockhill changed the title [MAINT, MRG] Fix warning [MAINT, MRG] Fix nilearn intersphinx Jun 24, 2022
@alexrockhill
Copy link
Contributor Author

This should be good to merge, it will fix one thing going wrong with the CIs today at least.

@larsoner larsoner merged commit 3ff8e9a into mne-tools:main Jun 24, 2022
@larsoner
Copy link
Member

Thanks @alexrockhill

@alexrockhill alexrockhill deleted the warn branch June 24, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants