observer and inject don't hoist static props of component

[satispunk]

Would be great that HOCs hoist static non-react props (methods).

Similar as it's done in {connect} from react-redux

[mattruby]

Could you use the wrappedComponent field to get to those methods?

On Jul 29, 2016 6:49 AM, "satispunk" notifications@github.com wrote:

Would be great that HOCs hoist static non-react props (methods).

Similar as it's done in {connect} from react-redux

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#92, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIrcv12wC4tdlrZtG0g2j8gExYV7e0xks5qaejAgaJpZM4JYHoe
.

[satispunk]

@mattruby observer does not have wrappedComponent field, doesn't it?

Anyway I would prefer that parent component should not know if child is wrapped component or not
and it looks not so nice

import Component from 'component'

export default () => {
    return <Component type={Component.wrappedComponent.Types.someType}>Some Child</Component> 
}

[mattruby]

I agree with you. I would like observer to feel completely transparent.
I'll try to take a look a little later today.

On Fri, Jul 29, 2016 at 8:18 AM, satispunk notifications@github.com wrote:

@mattruby https://github.com/mattruby observer does not have
wrappedComponent field, doesn't it?

Anyway I would prefer that parent component should not know if child is
wrapped component or not
and it looks not so nice

import Component from 'component'
export default () => {
return Some Child
}

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#92 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIrcrOaXYM-Iu_5FPnQx55b_biqjmYRks5qaf21gaJpZM4JYHoe
.

-Matt Ruby-
mattruby@gmail.com

[jtraub]

@mattruby actually, it is easy to copy connect behaviour with 2 lines of code, thanks to https://github.com/mridgway/hoist-non-react-statics

UPD: Redux uses it. See reduxjs/react-redux#127

[mweststrate]

N.b. note that just @observer (without store injection) is not a HoC but rather mixes functionality into the target component

[mweststrate]

Released as 3.5.4