Fix CJS build #261
Closed
Fix CJS build #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible duplicate with #254 |
|
Hi @msfeldstein! Thanks for this, but as @wangshijun mentioned, this is a duplicate of #254 which was just merged. |
|
awesome! Thanks for merging the other one. When do you expect the package
to get bumped?
…On Sat, Apr 5, 2025 at 3:57 PM Cliff Hall ***@***.***> wrote:
Hi @msfeldstein <https://github.com/msfeldstein>! Thanks for this, but as
@wangshijun <https://github.com/wangshijun> mentioned, this is a
duplicate of #254
<#254> which
was just merged.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHK325FLWSGBXRYEXEUX32YA7SPAVCNFSM6AAAAAB2QA26TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRGA4TCNJWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: cliffhall]*cliffhall* left a comment
(modelcontextprotocol/typescript-sdk#261)
<#261 (comment)>
Hi @msfeldstein <https://github.com/msfeldstein>! Thanks for this, but as
@wangshijun <https://github.com/wangshijun> mentioned, this is a
duplicate of #254
<#254> which
was just merged.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHK325FLWSGBXRYEXEUX32YA7SPAVCNFSM6AAAAAB2QA26TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRGA4TCNJWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
…rsion-0.8.1 Bump to version 0.8.1 - package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We need to use this in a vscode extension that can't be updated to use modules. pkce-challenge recently updated to 5.0.0 to support CJS so this makes it work here.
How Has This Been Tested?
Tested in said vscode extension.
The changelog from pkce-challenge 4.1-5.0 looks pretty harmless crouchcd/pkce-challenge@4.1.0...5.0.0
Breaking Changes
No
Types of changes
Checklist
Additional context