-
Notifications
You must be signed in to change notification settings - Fork 956
Jerome/fix/dev oauth server required scopes change #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jerome/fix/dev oauth server required scopes change #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change to just get git blame working well in gitlens+vscode.
"lockfileVersion": 3, | ||
"requires": true, | ||
"packages": { | ||
"": { | ||
"name": "@modelcontextprotocol/sdk", | ||
"version": "1.11.4", | ||
"version": "1.12.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also an unrelated change, just updating the lock to the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Fixes stubborn issue with inspector's OAuth reconnect problem when not going through debugger. That should get fixed as well, but arguably this works as well in the near term.
Removing required scope from the shttp dev oauth server. admittedly I don't know the best behaviour here:
As it currently stands, the inspector does both - guided flow requests all scopes, quick flow requests no scopes. I'm using this to test the inspector, and confused as to whether this oauth server is configured poorly (having required scopes for the MCP connection to function at all), or if the inspector quick flow is not functioning correctly (i.e. it should be requesting all available scopes)
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context