feat(NODE-7051): Normalize casing of shlwapi.lib

[tmm1]

I ran into this cross-compiling on a case-sensitive file-system. The official sdk uses Shlwapi.h and ShLwApi.Lib, but it is simplest to keep library names lowercase.

Description

What is changing?

Casing of -lshlwapi compile flag on windows, to ease cross-compilation.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Issue observed when using msvc on linux.

Improved dependency handling of shlwapi.lib

Library now handles situation on Windows where the casing of the library differs or the case sensitivity of the file system differs. Thanks to @tmm1 for the contribution.

Fill in title or leave empty for no highlight

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[durran]

Hi @tmm1 , thanks for the contribution. We've tracked in our JIRA project and will triage this early next week.

[durran]

Hi @tmm1 . The current existing casing we have, Shlwapi.* is matching what is in microsoft's documentation - could you provide more detail of the error you are getting?

[tmm1]

Windows file-system api is case-insensitive, and its recommended to use lowercase. See for example similar change here: nodejs/node-gyp#3189

When I download the SDK and look inside, here is what I see:

❯ find . -ls | grep -i shlw
  1318015     76 -rw-r--r--   1 root     root        74178 Jul 20 20:38 ./Windows\ Kits/10/Lib/10.0.26100.0/um/x64/ShLwApi.Lib
  1317921     80 -rw-r--r--   1 root     root        80504 Jul 20 20:38 ./Windows\ Kits/10/Lib/10.0.26100.0/um/x86/ShLwApi.Lib
  1317771    152 -rw-r--r--   1 root     root       153602 Jul 20 20:38 ./Windows\ Kits/10/Lib/10.0.26100.0/um/arm64/ShLwApi.Lib
  1317320    128 -rw-r--r--   1 root     root       127002 Jul 20 20:38 ./Windows\ Kits/10/Include/10.0.26100.0/um/Shlwapi.h

[durran]

Windows file-system api is case-insensitive, and its recommended to use lowercase. See for example similar change here: nodejs/node-gyp#3189

When I download the SDK and look inside, here is what I see:

❯ find . -ls | grep -i shlw
  1318015     76 -rw-r--r--   1 root     root        74178 Jul 20 20:38 ./Windows\ Kits/10/Lib/10.0.26100.0/um/x64/ShLwApi.Lib
  1317921     80 -rw-r--r--   1 root     root        80504 Jul 20 20:38 ./Windows\ Kits/10/Lib/10.0.26100.0/um/x86/ShLwApi.Lib
  1317771    152 -rw-r--r--   1 root     root       153602 Jul 20 20:38 ./Windows\ Kits/10/Lib/10.0.26100.0/um/arm64/ShLwApi.Lib
  1317320    128 -rw-r--r--   1 root     root       127002 Jul 20 20:38 ./Windows\ Kits/10/Include/10.0.26100.0/um/Shlwapi.h

Ah ok. All over the place - thanks for that. :)