feat: add session management for streamableHttp [MCP-52] #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/common/sessionStore.ts
Outdated
| import logger, { LogId } from "./logger.js"; | ||
|
|
||
| export class SessionStore { | ||
| private sessions: { [sessionId: string]: StreamableHTTPServerTransport | undefined } = {}; |
There was a problem hiding this comment.
[q] Is there a reason why they value is nullable?
I don't see any location where the value (StreamableHTTPServerTransport) is set to undefined/removed
There was a problem hiding this comment.
for the case where a key is not found
src/transports/streamableHttp.ts
Outdated
| app.use(express.json()); | ||
|
|
||
| const handleRequest = async (req: express.Request, res: express.Response) => { | ||
| const sessionId = req.headers["mcp-session-id"] as string; |
There was a problem hiding this comment.
Wouldn't the better way to write this be:
const sessionId = req.headers["mcp-session-id"];
if (typeof sessionId !== 'string' || !sessionId) {Or at least use as string | undefined, instead of as string, which is incorrect?
There was a problem hiding this comment.
good catch, I had an issue on my IDE before I think
src/transports/streamableHttp.ts
Outdated
| const transport = new StreamableHTTPServerTransport({ | ||
| sessionIdGenerator: undefined, | ||
| }); | ||
| const sessionId = req.headers["mcp-session-id"] as string; |
There was a problem hiding this comment.
Same as previous remark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
add session management for streamableHttp
Checklist