Skip to content

test(NODE-7065): unskip langchainjs tests #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025
+15 −12
Merged

test(NODE-7065): unskip langchainjs tests #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c3908d
test(NODE-7030): unskip langchainjs tests
durran Jul 28, 2025
73f214f
chore: re-export env vars to langchainjs expected ones
durran Jul 30, 2025
456a1a1
fix: lint
durran Jul 30, 2025
2e417b2
chore: fix strip of backslash
durran Jul 30, 2025
61b3d60
chore: move back to core repo
durran Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,17 +432,16 @@ buildvariants:
tasks:
- name: test-langchaingo-local

# TODO: INTPYTHON-667
# - name: test-langchain-js-ubuntu
# display_name: LangchainJS Ubuntu2204
# tags: [javascript]
# expansions:
# DIR: langchain-js
# run_on:
# - ubuntu2204-small
# tasks:
# - name: test-langchain-js-local
# - name: test-langchain-js-remote
- name: test-langchain-javascript-ubuntu
display_name: LangchainJS Ubuntu2204
tags: [javascript]
expansions:
DIR: langchain-js
run_on:
- ubuntu2204-small
tasks:
- name: test-langchain-js-local
- name: test-langchain-js-remote

- name: test-mem0-python-rhel
display_name: mem0 RHEL Python
Expand Down
6 changes: 5 additions & 1 deletion langchain-js/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ setup_langchain_integration() {

yarn add --dev jest-junit
export JEST_JUNIT_OUTPUT_NAME=results.xml

# Trim trailing slashes since lanchainjs is doing string manipulationn, not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What trailing slashes are we talking about here? Should the secrets just be updated to not have trailing slashes instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing "/" in the URL from the secrets. I don't really think we should change the secret itself. Rather I'd say the ideal thing would be for langchain to update their generation of the Azure endpoint to use the URL class and not straight string manipulation.

# using the URI class.
AZURE_OPENAI_BASE_PATH=$(echo "$AZURE_OPENAI_ENDPOINT" | sed 's:/*$::')
export AZURE_OPENAI_BASE_PATH
export AZURE_OPENAI_API_VERSION=$OPENAI_API_VERSION
# optionally enable to debug local atlas in CI.
# export DEBUG=testcontainers*
}
Expand Down