DOCSP-49867: Add JsonReader example #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mcmorisi
commented
May 20, 2025
| @@ -87,5 +104,4 @@ documentation: | |||
| - `JsonWriter <{+new-api-root+}/MongoDB.Bson/MongoDB.Bson.IO.JsonWriter.html>`__ | |||
| - `JsonReader <{+new-api-root+}/MongoDB.Bson/MongoDB.Bson.IO.JsonReader.html>`__ | |||
| - `JsonWriterSettings <{+new-api-root+}/MongoDB.Bson/MongoDB.Bson.IO.JsonWriterSettings.html>`__ | |||
| - `JsonReaderSettings <{+new-api-root+}/MongoDB.Bson/MongoDB.Bson.IO.JsonReaderSettings.html>`__ | |||
There was a problem hiding this comment.
According to Rishit and Boris, this isn't worth discussing.
rustagir
approved these changes
May 20, 2025
mcmorisi
requested review from
a team,
papafe and
rstam
and removed request for
a team and
papafe
rstam
suggested changes
May 21, 2025
| Console.WriteLine(document.ToJson()); | ||
| } | ||
| // end-read-ejson-reader | ||
| } |
There was a problem hiding this comment.
There's a much easier way to parse JSON into a BsonDocument:
var document = BsonDocument.Parse(json);
There was a problem hiding this comment.
I'm not sure what the point of this example is. It's just a harder way to do something that can be done more simply.
There was a problem hiding this comment.
So for context, the topic list I've been working off of lists JsonReader as a class to discuss.
If you don't feel that a JsonReader example is necessary for understanding Extended JSON then I'm fine to cancel this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49867
Staging Links
Self-Review Checklist