DOCSP-50559: query guids #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I don't think we should have a separate section for "Query GUIDs". The users will then expect an example that includes Builders and LINQ as well along with the BSON based example mentioned there. Just a simple callout note on how to construct/work with legacy GUIDs should be good. The Upgrade guide can then just link to that callout. |
|
The BSONBinaryData.Create example in the v3 upgrade guide is applicable to the new GUIDs as well. I suggest that we should change the text to "To view an example for using legacy GUIDs, see the Construct Legacy GUIDs note in the GUID Serialization guide." That ways we are being explicit. |
rishitb-mongodb
approved these changes
Jun 10, 2025
rustagir
added a commit
that referenced
this pull request
Jun 10, 2025
* DOCSP-50559: query guids * RB restructure * RB small fix (cherry picked from commit 004a229)
rustagir
added a commit
that referenced
this pull request
Jun 10, 2025
* DOCSP-50559: query guids * RB restructure * RB small fix (cherry picked from commit 004a229)
rustagir
added a commit
that referenced
this pull request
Jun 10, 2025
* DOCSP-50559: query guids * RB restructure * RB small fix (cherry picked from commit 004a229)
rustagir
added a commit
that referenced
this pull request
Jun 10, 2025
* DOCSP-50559: query guids * RB restructure * RB small fix (cherry picked from commit 004a229)
rustagir
added a commit
that referenced
this pull request
Jun 10, 2025
* DOCSP-50559: query guids * RB restructure * RB small fix (cherry picked from commit 004a229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-50559
Staging Links
Self-Review Checklist