Skip to content

DOCSP-50960: Install with pie #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2025
Merged

DOCSP-50960: Install with pie #278

merged 5 commits into from
Jul 1, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jul 1, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50960

Staging Links

  • get-started
  • references/upgrade

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?
    • Did you add redirects?

    @netlify Netlify
    Copy link

    netlify bot commented Jul 1, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-php-library ready!

    Name Link
    🔨 Latest commit fb98c18
    🔍 Latest deploy log https://app.netlify.com/projects/docs-php-library/deploys/686426b5372610000868ebf9
    😎 Deploy Preview https://deploy-preview-278--docs-php-library.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 1, 2025 •
    edited
    Loading

    🔄 Deploy Preview for docs-php-library processing

    Item Details
    🔨 Latest Commit b7f89c8dbf3681cc626780fd5564e403beb4e9fb
    😎 Deploy Preview https://deploy-preview-278--docs-php-library.netlify.app
    🔍 Build Logs View Logs

    rustagir
    rustagir approved these changes Jul 1, 2025
    View reviewed changes
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    source/references/upgrade.txt

    .. code-block:: bash

    pecl upgrade mongodb-<version-number>
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: should we add a sudo here?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The official pecl docs don't mention sudo, I don't think this is required by default. I can mess with the filesystem permissions. I would remove the sudo.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ok, since it's not in the pecl docs I'll remove

    source/get-started.txt Outdated
    Comment on lines 79 to 80
    If you want to install a {+extension-short+} version before v1.21,
    use the :php:`pecl command <mongodb.installation#mongodb.installation.pecl>`.
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    If you want to install a {+extension-short+} version before v1.21,
    use the :php:`pecl command <mongodb.installation#mongodb.installation.pecl>`.
    To install a {+extension-short+} version before v1.21,
    you must use the :php:`pecl command <mongodb.installation#mongodb.installation.pecl>`.

    @norareidy norareidy mentioned this pull request Jul 1, 2025
    Open
    1 task
    @norareidy norareidy requested a review from GromNaN July 1, 2025 16:32
    GromNaN
    GromNaN requested changes Jul 1, 2025
    View reviewed changes
    Copy link
    Member

    @GromNaN GromNaN left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    pie being a new tool, I don't expect people to have it installed yet. Can you add a link to the pie install instructions: https://github.com/php/pie/blob/main/docs/usage.md

    source/get-started.txt Outdated
    php --ini
    pie install mongodb/mongodb-extension^{+full-version+}

    Tto install a {+extension-short+} version before v1.21, you must
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    Tto install a {+extension-short+} version before v1.21, you must
    To install a {+extension-short+} version before v1.21, you must

    source/get-started.txt Outdated

    .. code-block:: bash

    php --ini
    pie install mongodb/mongodb-extension^{+full-version+}
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The colon is missing:

    Suggested change
    pie install mongodb/mongodb-extension^{+full-version+}
    pie install mongodb/mongodb-extension:^{+full-version+}

    @norareidy norareidy requested a review from GromNaN July 1, 2025 18:24
    @norareidy norareidy merged commit 90ce43c into mongodb:comp-cov Jul 1, 2025
    7 checks passed
    @norareidy norareidy deleted the DOCSP-50960-pie-install branch July 1, 2025 20:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @GromNaN GromNaN GromNaN approved these changes

    @rustagir rustagir rustagir approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @norareidy @docs-builder-bot @GromNaN @rustagir