Using push and pull with a Model instance

[nsebban]

My issue is related to this one.

I have a User model, that has a 'friends' property that is an array. I would like to push and pull references to other users in it.

I thought the ::pull and ::push methods were exactly for that, but even though I can use them on a specific instance of my model, they have an effect on every single record on my collection, and not only on the one corresponding to my Model instance.

I'm not sure if it's a bug or a feature. In this other entry you mention the documentation, but I didn't find any specific information on that topic, beside an example.

Can someone please tell me a bit more about this ? Thanks a lot in advance.

[brunocascio]

Hey!

Check my method:

public function addFav() 
    {
        $user = Auth::user(); //Obtengo usuario actual

        $new_friend = User::find(Input::json('friend_id'));

        if ( $new_friend && $user->_id != $new_friend->_id ) 
        {
            // Chequeo que no sea un favorito actualmente
            $friends = $user->friendships; 

            foreach ( $friends as $friend ) {
                if ( $friend['_id'] == $new_friend->_id )
                    return Response::json(['message' => 'Ya es un favorito.'], 400);
            }

            // Datos del usuario agregado
            $data = array( 
                                '_id'               => $new_friend->_id,
                                'username'      => $new_friend->username,
                                'profile_pic'   => $new_friend->profile_pic,
            );

            // Datos sobre mi
            $dataMe = array( 
                                '_id'               => $user->_id,
                                'username'      => $user->username,
                                'profile_pic'   => $user->profile_pic,
            );

            // guardo el usuario agregado en el actual
            DB::collection('users')->where('_id', $user->_id)->push('friendships', $data);

            // guardo mis datos en el usuario agregado
            DB::collection('users')->where('_id', $new_friend->_id)->push('friends_with_me', $dataMe);

            return Response::json(['data' => $dataMe ]);
        }

        return Response::json(['message' => 'Bad request'], 400);
    }

[jenssegers]

You are correct, I was able to reproduce the issue. Will push an update in a few minutes.

[jenssegers]

You can now correctly push to model instances.

[nsebban]

It now works wonders. Thank you for providing a quick fix !

[jenssegers]

It seems that there is a similar issue with pull as wel.

[nsebban]

Definitely.
No idea if more methods have the same issue though, since I only use ::push and ::pull right now.

[nsebban]

Just tested the ::pull method, and as expected it still has an effect on every single record on my collection, and not only on the one corresponding to my Model instance.

Would that do the trick ?

/**
* Pass pull to the query builder.
*
* @return mixed
*/
public function pull()
{
    if ($parameters = func_get_args())
    {
        $query = $this->setKeysForSaveQuery($this->newQuery());
        return call_user_func_array(array($query, 'pull'), $parameters);
    }
    return parent::pull();
}

Edit : I don't think I can re-open the issue :/

[jenssegers]

I'm working on a fix. But there seems to be an additional issue with belongsToMany relations that needs to be solved.

[jenssegers]

Is fixed now, as well as belongsToMany relations.