Fixed queue attempts bug #1535
Closed
Fixed queue attempts bug #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatisdukurs
commented
Jun 8, 2018
gatisdukurs
commented
- Fixed queue attempts bug, now attempts are increased only when job gets pulled from the queue.
- Removed unnecessary reserved flag for job since reserved_at already does the job.
- Fixed Docker file error (travis builds where failing).
- Fixed wrong queue attempts - Removed unnecessary reserved flag
|
@jenssegers please, take a look at my pull request, tested with laravel 5.6 and supervisor with multiple workers. Currently queue is broken in master and Docker file is broken for builds. Thanks |
|
up |
|
Looks like it was fixed and merged in #1855 Should be closed then. cc @Smolevich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.