-
Notifications
You must be signed in to change notification settings - Fork 209
Fix foreach after the garbage collector is invoked #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danog
wants to merge
45
commits into
mongodb:v2.x
Choose a base branch
from
danog:fix_foreach
base: v2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danog
commented
Jul 24, 2025
This was referenced Jul 24, 2025
Fixed up everything! |
The codebase was successfully formatted using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1776, https://jira.mongodb.org/browse/PHPC-2505, and the equivalent bug triggered when assigning dynamic properties and then unsetting them again.
The underlying issue in both cases is the invocation of
zend_std_get_properties
, which populates theproperties
hashtable in the zend object (not in the interned mongo one).This, in turn, causes the iteration logic to completely skip iteration due to the
if (zend_hash_num_elements(properties) == 0) {
check in theZEND_FE_RESET_R_SPEC_CV_HANDLER
The fix adds custom handlers for
get_property
,write_property
,unset_property
,has_property
,get_property_ptr_ptr
which use a new interned php_properties hashtable, instead of the zend hashtable property.The
zend_gc
handler is also modified to invokeget_properties
instead ofzend_std_get_properties
.The overall implementation mostly works as expected, the only issue is some strange refcounting behavior within the garbage collector on the hashtable returned by get_gc, which sometimes increments the refcount without decrementing it again, leading to a leak of the interned
properties
hashtable (detectable using ASAN); I have asked clarifications regarding that, marking the PR as draft in the meantime.There's also a leftover issue with foreach loops not exiting for whatever reason, still looking into that.