PHPC-632: Define MONGOC_NO_AUTOMATIC_GLOBALS when bundling libmongoc #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that libmongoc's automatic destructor is disabled and will avoid segfaults during abrupt FPM shutdowns for static builds. Those using the driver with system libmongoc will need to wait for CDRIVER-1160 to be released in order to resolve this issue. Fixes mongodb#209, fixes mongodb#258
|
Manually merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-632
This ensures that libmongoc's automatic destructor is disabled and will avoid segfaults during abrupt FPM shutdowns for static builds. Those using the driver with system libmongoc will need to wait for CDRIVER-1160 to be released in order to resolve this issue.
This fixes #209 and #258 (for bundled libmongoc). It may also fix #212, #213, and #215.