changes to risk form validation fixes #883 #1170

tiftran · 2019-04-09T18:19:19Z

No description provided.

glasserc

Should we add something to the edit_risks.html JavaScript to mirror the way we handle the technical risk field?

glasserc · 2019-04-11T18:16:09Z

app/experimenter/experiments/forms.py

+        return cleaned_data
+
+    def _validate_risk(self, cleaned_data):
+        if True in cleaned_data.values():


Hmm! This is a little too clever for my taste. I'd probably prefer if any([cleaned_data.risk_internal_only, cleaned_data.risk_partner_related, cleaned_data.risk_brand, ...]).

jaredlockhart · 2019-04-17T18:17:41Z

@tiftran Sorry for the hold up, I've looked at this but I think I need to talk to @shell1 about changes we're making to forms in general to figure out how this should look. Sorry for the delay! -_-'

glasserc

I'll hold off on approving this since Jared has opinions about it. One drive-by comment..

glasserc · 2019-04-18T17:58:09Z

app/experimenter/templates/experiments/edit_risks.html

          $('#risks_field').show();
        } else {
          $('#risks_field').hide();
        }
      }
-
+      


Whitespace change?

let me fix that...

tiftran · 2019-04-22T17:34:55Z

Closing as discussed during standup with @jaredkerim and @shell1 that behaviour of required has changed.

…ests (#12712) Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.6.1 to 3.7.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst">pytest-xdist's changelog</a>.</em></p> <blockquote> <h1>pytest-xdist 3.7.0 (2025-05-26)</h1> <h2>Features</h2> <ul> <li> <p><code>[#1142](pytest-dev/pytest-xdist#1142) <https://github.com/pytest-dev/pytest-xdist/issues/1142></code>_: Added support for Python 3.13.</p> </li> <li> <p><code>[#1144](pytest-dev/pytest-xdist#1144) <https://github.com/pytest-dev/pytest-xdist/issues/1144></code>_: The internal <code>steal</code> command is now atomic - it unschedules either all requested tests or none.</p> <p>This is a prerequisite for group/scope support in the <code>worksteal</code> scheduler, so test groups won't be broken up incorrectly.</p> </li> <li> <p><code>[#1170](pytest-dev/pytest-xdist#1170) <https://github.com/pytest-dev/pytest-xdist/issues/1170></code>_: Add the <code>--px</code> arg to create proxy gateways.</p> <p>Proxy gateways are passed to additional gateways using the <code>via</code> keyword. They can serve as a way to run multiple workers on remote machines.</p> </li> <li> <p><code>[#1200](pytest-dev/pytest-xdist#1200) <https://github.com/pytest-dev/pytest-xdist/issues/1200></code>_: Now multiple <code>xdist_group</code> markers are considered when assigning tests to groups (order does not matter).</p> <p>Previously, only the last marker would assign a test to a group, but now if a test has multiple <code>xdist_group</code> marks applied (for example via parametrization or via fixtures), they are merged to make a new group.</p> </li> </ul> <h2>Removals</h2> <ul> <li><code>[#1162](pytest-dev/pytest-xdist#1162) <https://github.com/pytest-dev/pytest-xdist/issues/1162></code>_: Dropped support for EOL Python 3.8.</li> </ul> <h2>Trivial Changes</h2> <ul> <li> <p><code>[#1092](pytest-dev/pytest-xdist#1092) <https://github.com/pytest-dev/pytest-xdist/issues/1092></code>_: Update an error message to better indicate where users should go for more information.</p> </li> <li> <p><code>[#1190](pytest-dev/pytest-xdist#1190) <https://github.com/pytest-dev/pytest-xdist/issues/1190></code>_: Switched to using a SPDX license identifier introduced in PEP 639.</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/b561916eaf6ec0a8a448ed0bcc90a351ab3c58e3"><code>b561916</code></a> Release 3.7.0</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/71bd3ede1982a65cf74cf248c0ba906fe6062ce7"><code>71bd3ed</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1204">#1204</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/65de0ab30e602a5f466b8746fcfff0cf0945b600"><code>65de0ab</code></a> Join multiple xdist_group markers (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1201">#1201</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/199f949716792db8745a69444091f4d4fddae0e2"><code>199f949</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1202">#1202</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/b0215da1edf369d5b63b7811b41d750bb5ebb072"><code>b0215da</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1199">#1199</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/18e47853ed9272a87b9e6d29b1630f854d458d4a"><code>18e4785</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1198">#1198</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/731c05d86ad3a42e0b2e3d3b4c8cdd5e33e81988"><code>731c05d</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1197">#1197</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/16c5be32031f904a5f48c2cdbf3424f6528af3b0"><code>16c5be3</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1195">#1195</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/e03757a1d77805776babf6faa73b696ea36c001c"><code>e03757a</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1193">#1193</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-xdist/commit/f1d81a4402e611dca7ae5bf4b892decfef9d4f08"><code>f1d81a4</code></a> Merge pull request <a href="https://redirect.github.com/pytest-dev/pytest-xdist/issues/1192">#1192</a> from adamchainz/document_disabling</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-xdist/compare/v3.6.1...v3.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pytest-xdist&package-manager=pip&previous-version=3.6.1&new-version=3.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

changes to risk form validation fixes mozilla#883

622ed44

tiftran requested a review from jaredlockhart April 9, 2019 18:31

glasserc reviewed Apr 11, 2019

View reviewed changes

changed if statement to specify cleaned values

9233871

tiftran requested a review from glasserc April 11, 2019 23:00

glasserc reviewed Apr 18, 2019

View reviewed changes

changes to edit_risk for risks to mirror technical risk

46dfd2c

tiftran force-pushed the 883 branch from 24b9664 to 46dfd2c Compare April 18, 2019 22:25

tiftran closed this Apr 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

changes to risk form validation fixes #883 #1170

changes to risk form validation fixes #883 #1170

Uh oh!

tiftran commented Apr 9, 2019

Uh oh!

glasserc left a comment

Uh oh!

glasserc Apr 11, 2019

Uh oh!

jaredlockhart commented Apr 17, 2019

Uh oh!

glasserc left a comment

Uh oh!

glasserc Apr 18, 2019

Uh oh!

tiftran Apr 18, 2019

Uh oh!

tiftran commented Apr 22, 2019

Uh oh!

Uh oh!

changes to risk form validation fixes #883 #1170

changes to risk form validation fixes #883 #1170

Uh oh!

Conversation

tiftran commented Apr 9, 2019

Uh oh!

glasserc left a comment

Choose a reason for hiding this comment

Uh oh!

glasserc Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

jaredlockhart commented Apr 17, 2019

Uh oh!

glasserc left a comment

Choose a reason for hiding this comment

Uh oh!

glasserc Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

tiftran Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

tiftran commented Apr 22, 2019

Uh oh!

Uh oh!