Fixed Limit and Offset Support bugs when using Subqueries in where cl…

[liuhuagui]

Hi, I haved tried to fix a bug of Limit and Offset Support when using Subqueries in where clauses.
My code:

   @Override
    default List<MyMark> list(MyMark record) {
        Page page = record.getPage();
        return MyBatis3Utils.selectList(this::selectMany,
                columns,myMark,
                q->q.leftJoin(originalArticle).on(originalArticleId,equalTo(originalArticle.id))
                .where(id,isLessThanOrEqualTo(
                        select(id).from(myMark)
                        .orderBy(updateTime.descending(),createTime.descending())
                        .limit(1L)
                        .offset(page.getOffset())
              )).orderBy(sortColumn("mutime").descending(),sortColumn("mctime").descending()).limit(page.getSize())
        );
    }

Final statement as follows:

select my_mark.id as mid, my_mark.consultant_id, my_mark.original_article_id, my_mark.create_time as mctime, my_mark.update_time as mutime, original_article.id, original_article.category_id, original_article.author_id, original_article.title, original_article.summary, original_article.thumb_pic, original_article.paragraph_id, original_article.relayed_read_count, original_article.read_count, original_article.marked_count, original_article.is_readable, original_article.create_time, original_article.update_time from my_mark left join original_article on my_mark.original_article_id = original_article.id where my_mark.id <= (select id from my_mark order by update_time DESC, create_time DESC limit #{parameters._limit} offset #{parameters._offset}) order by update_time DESC, create_time DESC limit #{parameters._limit}

Exception as follows:

### SQL: select my_mark.id as mid, my_mark.consultant_id, my_mark.original_article_id, my_mark.create_time as mctime, my_mark.update_time as mutime, original_article.id, original_article.category_id, original_article.author_id, original_article.title, original_article.summary, original_article.thumb_pic, original_article.paragraph_id, original_article.relayed_read_count, original_article.read_count, original_article.marked_count, original_article.is_readable, original_article.create_time, original_article.update_time from my_mark left join original_article on my_mark.original_article_id = original_article.id where my_mark.id <= (select id from my_mark order by update_time DESC, create_time DESC limit ? offset ?) order by update_time DESC, create_time DESC limit ?
### Cause: java.sql.SQLException: Subquery returns more than 1 row
; bad SQL grammar []; nested exception is java.sql.SQLException: Subquery returns more than 1 row

[jeffgbutler]

Thanks for reporting this issue! This PR breaks a lot of tests, so we can't merge it unless it is changed. Also, you would need to add a test for this issue.

[liuhuagui]

Okay, I'll do that.

[coveralls]

Coverage remained the same at 100.0% when pulling bf04ee7 on liuhuagui:master into 65f9784 on mybatis:master.

[jeffgbutler]

Pleas add a space before the new parameter

[jeffgbutler]

Please add a space before the new parameter

[jeffgbutler]

Remove this method - sequence is not optional

[jeffgbutler]

Please add a space before the new parameter

[jeffgbutler]

Please add a space before the new parameter

[jeffgbutler]

Please use the same pattern as the other parameters: sequence = Objects.requireNonNull(builder.sequence)

[jeffgbutler]

Thanks for your contribution!

[liuhuagui]

I should thank you for your project.