refactor: convert thiserror to snafu and remove anyhow in public apis #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No backtraces yet!
rklaehn
changed the title
ramfox
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
This looks like a very sane way to go about it. Using the Cases to group and then making the errors transparent, so that we "essentially" have all the cases in the GetError, but they are still logically grouped if someone is looking to understand what happened in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ramfox I think this one is the best of 2 bad alternatives. WDYT?
At least all the plumbing does not appear in the docs since the XXXCases enums are in a private module...